[x265] [PATCH 1 of 3] optimize: rewrite TComTrQuant::xGetCodedLevel

Steve Borho steve at borho.org
Fri Mar 21 20:20:58 CET 2014


On Fri, Mar 21, 2014 at 2:06 PM, chen <chenm003 at 163.com> wrote:
>
>
>
> At 2014-03-21 09:41:39,"Steve Borho" <steve at borho.org> wrote:
>>On Tue, Mar 18, 2014 at 7:34 PM, Min Chen <chenm003 at 163.com> wrote:
>>> # HG changeset patch
>>> # User Min Chen chenm003 at 163.com>
>>> # Date 1395189192 25200
>>> # Node ID e9f08d038ff0dc17152002d2b2b70138d08465d7
>>> # Parent  dc700298419d382e58c49d4ea62a3d7398b4beaf
>>> optimize: rewrite TComTrQuant::xGetCodedLevel
>>>
>>> -inline double TComTrQuant::xGetICRateCost(uint32_t absLevel,
>>> +FORCEINLINE double TComTrQuant::xGetICRateCost(uint32_t absLevel,
>>
>>this macro isn't defined for all compilers:
>>
>>/Users/steve/repos/x265/source/Lib/TLibCommon/TComTrQuant.cpp:1204:1:
>>error: unknown type name 'FORCEINLINE'
>
> FORCEINLINE  defined in winnt.h and we used in threading.h

right, it's only used within an #if defined(_MSC_VER) block

> btw: we defined this macro in old vector code, but remove later

It was always defined in just a couple of files.

I've queued these patches locally with FORCEINLINE returned to just
`inline` and am running tests.

If you like you can make a new patch which adds X265_FORCEINLINE to
common.h that does compiler-specific inline overrides and then use it
here.

-- 
Steve Borho


More information about the x265-devel mailing list