[x265] [PATCH] api: add param.bRepeatHeaders - insert stream headers in each keyframe NAL

Steve Borho steve at borho.org
Thu Mar 27 19:48:20 CET 2014


On Thu, Mar 27, 2014 at 10:42 AM, Tim Walker <tdskywalker at gmail.com> wrote:
> On 27 Mar 2014, at 16:39, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
>
>> On 3/27/2014 1:08 PM, Tim Walker wrote:
>>> FWIW, the Libav/FFmpeg wrapper already checks for return values < 0 (x265.h claims x265_encoder_headers returns negative on error, even before your patch).
>>
>> It will continue to work even with the change, indeed.
>>
>> - Derek
>
> It's actually broken right now because the function returns 0 on error, contrary to what the documentation says.

Yep, if one of the input pointers was NULL it was returning zero.  I
snuck a fix for that into my patch.

It sounds like it will be safe to push this, so I've queued it locally.

-- 
Steve Borho


More information about the x265-devel mailing list