[x265] CMake 3.1.0-rc1 changed policies (/VisualLeakDetector)

[Steve Borho]

On 11/12, LigH wrote:
> I just renewed my building environment on one PC, and got some warning while
> preparing a build:
> 
> +----
> -- cmake version 3.1.0-rc1
> -- The C compiler identification is GNU 4.8.2
> -- The CXX compiler identification is GNU 4.8.2
> -- Check for working C compiler:
> H:/MSYS/mingw/bin/x86_64-w64-mingw32-gcc.exe
> -- Check for working C compiler:
> H:/MSYS/mingw/bin/x86_64-w64-mingw32-gcc.exe -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler:
> H:/MSYS/mingw/bin/x86_64-w64-mingw32-g++.exe
> -- Check for working CXX compiler:
> H:/MSYS/mingw/bin/x86_64-w64-mingw32-g++.exe -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Detected x86 target processor
> -- Looking for include file inttypes.h
> -- Looking for include file inttypes.h - found
> -- Performing Test CC_HAS_NO_NARROWING
> -- Performing Test CC_HAS_NO_NARROWING - Success
> -- Performing Test CC_HAS_NO_ARRAY_BOUNDS
> -- Performing Test CC_HAS_NO_ARRAY_BOUNDS - Success
> -- Performing Test CC_HAS_FAST_MATH
> -- Performing Test CC_HAS_FAST_MATH - Success
> -- Performing Test CC_HAS_STACK_REALIGN
> -- Performing Test CC_HAS_STACK_REALIGN - Success
> -- Performing Test CC_HAS_FNO_EXCEPTIONS_FLAG
> -- Performing Test CC_HAS_FNO_EXCEPTIONS_FLAG - Success
> -- Found yasm: H:/MSYS/bin/yasm.exe (found version "1.2.0")
> -- Found Yasm 1.2.0 to build assembly primitives
> CMake Warning (dev) at cmake/FindVLD.cmake:57 (FIND_PATH):
>   Policy CMP0053 is not set: Simplify variable reference and escape sequence
>   evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use
> the
>   cmake_policy command to set the policy and suppress this warning.
> 
>   For input:
> 
>     '$ENV{PROGRAMFILES(X86)}/Visual Leak Detector'

>   the old evaluation rules produce:
> 
>     '/Visual Leak Detector'
> 
>   but the new evaluation rules produce an error:
> 
>     Syntax error in cmake code at
>       H:/MSYS/home/Verwaltung/x265/source/cmake/FindVLD.cmake:61
>     when parsing string
>       $ENV{PROGRAMFILES(X86)}/Visual Leak Detector
>     Invalid character ('(') in a variable name: 'PROGRAMFILES'

If you edit line 61 of x265/source/cmake/FindVLD.cmake and
change

  "$ENV{PROGRAMFILES(X86)}/Visual Leak Detector"                                                                            

to

  "$ENV{PROGRAMFILES\(X86\)}/Visual Leak Detector"                                                                            

Does it make cmake 3.1 happy?

-- 
Steve Borho