[x265] Fwd: [PATCH] refactorizaton of the transform/quant path

[Praveen Tiwari]

---------- Forwarded message ----------
From: Steve Borho <steve at borho.org>
Date: Tue, Nov 18, 2014 at 11:31 PM
Subject: Re: [x265] [PATCH] refactorizaton of the transform/quant path
To: Development for x265 <x265-devel at videolan.org>


On 11/18, praveen at multicorewareinc.com wrote:
> # HG changeset patch
> # User Praveen Tiwari
> # Date 1416299427 -19800
> # Node ID 706fa4af912bc1610478de8f09a651ae3e58624c
> # Parent  2f0062f0791b822fa932712a56e6b0a14e976d91
> refactorizaton of the transform/quant path.
> This patch involves scaling down the DCT/IDCT coefficients from int32_t
to int16_t
> as they can be accommodated on int16_t without any introduction of encode
error,
> this allows us to clean up lots of DCT/IDCT intermediated buffers,
optimize enode efficiency for different
> cli options including noise reduction by reducing data movement
operations, accommodating more number of
> coefficients in a single register for SIMD operations. This patch include
all necessary
> changes for the transfor/quant path including unit test code.

<snip>

>      for (int pass = 0; pass < 2; pass++)
> @@ -1564,7 +1418,7 @@
>       * still somewhat rare on end-user PCs we still compile and link
these SSE3
>       * intrinsic SIMD functions */
>  #if !HIGH_BIT_DEPTH
> -    p.idct[IDCT_8x8] = idct8;
> +//    p.idct[IDCT_8x8] = idct8;
>      p.idct[IDCT_16x16] = idct16;
>      p.idct[IDCT_32x32] = idct32;
>  #endif

>>Getting the intrinsic idct8 re-enabled or coded in assembly should be a
>>priority.

[MC] We don't have any sse version of assembly code for IDCT_16x16
and IDCT_32x32, only avx2  asm codes this is why intrinsic version is
enabled. (We have AVX2 assembly for these two functions, but since AVX2 is
still somewhat rare on end-user PCs we still compile and link these SSE3
intrinsic SIMD functions). Further I will clean up idct8 intrinsic
(disabled) code as we have sse and avx2 asm code for it so, I think it is
no longer useful.

--
Steve Borho
_______________________________________________
x265-devel mailing list
x265-devel at videolan.org
https://mailman.videolan.org/listinfo/x265-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20141119/0f9353f6/attachment.html>