[x265] [PATCH 2 of 2] cmake: add build option for Windows to target Win7 to enable NUMA APIs

Tim W. tdskywalker at gmail.com
Mon Apr 13 23:34:25 CEST 2015


On Mon, Apr 13, 2015 at 10:30 PM, Steve Borho <steve at borho.org> wrote:

> On 04/13, Xinyue Lu wrote:
> > Hi,
> >
> > That's correct.
> >
> > Per our discussion on IRC channel:
> >
> > The NUMA API is only available on Win7 and above.
> >
> > So either compiling against Win7 and you get the NUMA API, or
> > compiling against Vista (or even XP) which doesn't come with NUMA
> > support.
>
> I've modified the patch locally to simplify the situation by targeting
> Win7 (with NUMA) by default unless WINXP_SUPPORT is enabled. So Vista
> gets glommed together with XP as a "legacy" O/S option.
>

Seems reasonable, except the option name is somewhat wrong now; people may
decide not to specify WINXP_SUPPORT only to get bitten when it doesn't run
under Vista?

Tim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150413/327ce537/attachment.html>


More information about the x265-devel mailing list