[x265] [PATCH 2 of 2] cmake: add build option for Windows to target Win7 to enable NUMA APIs

[Tim W.]

On Tue, Apr 14, 2015 at 5:41 AM, Steve Borho <steve at borho.org> wrote:

> I'm open to suggestions (perhaps LEGACY_WINDOWS) but you have to keep in
> mind the cmake cache which keeps old options around until you manually
> delete the cache or delete the build folder. So WINXP_SUPPORT will still
> show up in the list of options for everyone for quite some time, and
> they might be quite confused if they turned on WINXP_SUPPORT and it had
> no effect.
>
> We could change the logic to be something like this:
>
> option(LEGACY_WINDOWS "Make binaries compatible with Windows XP and Vista"
> OFF)
> if(LEGACY_WINDOWS OR WINXP_SUPPORT)
>  ...
>
> which keeps the old option still effective, but then we have two options
> that have the same effect. This is why I left the old option name in
> place and just updated the description to mention XP and Vista.
>

Maybe I'm being too picky. Your patch looks OK, you could just go with it
and see how many users actually have an issue with it, might end up being
no-one at all.

Tim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150415/75d53cd2/attachment.html>