[x265] [PATCH] fix build warning in quant.cpp

[Steve Borho]

On 04/19, Min Chen wrote:
> # HG changeset patch
> # User Min Chen <chenm003 at 163.com>
> # Date 1429433044 -28800
> # Node ID ecf92b3cfb11a6202c35a1fde44f18aa961ce519
> # Parent  bdee7c3b7853d7860cb15d649da4dc61d59a428c
> fix build warning in quant.cpp

I've rolled this patch into the last patch of your most recent series
and have the series queued up after the qg-size patches locally, and it
seems to conflict with them, or expose a bug.  When I run the smoke
tests I get check failures:

[3/33] testing x265-gcc big_buck_bunny_360p24.y4m --preset=slower
--no-weightp --cu-stats --pme --qg-size 16 -f50 --hash=1 --no-info
extras: --psnr --ssim ... x265 [error]: count of coeff failure
encoder warning or error reported

[9/33] testing x265-gcc old_town_cross_444_720p50.y4m --preset=slow
--sao-non-deblock --pmode --qg-size 32 -f50 --hash=1 --no-info
extras: --psnr --ssim ... x265 [error]: count of coeff failure
encoder warning or error reported


and many other tests change outputs, which I don't believe was expected
from your series?

[2/33] testing x265-gcc big_buck_bunny_360p24.y4m --preset=medium
--bitrate 1000 -F4 --cu-lossless --scaling-list default -f50 --hash=1
--no-info
extras: --psnr --ssim ... FAIL
OUTPUT CHANGE: <bitrate: 1129.16, SSIM: 26.585, PSNR: 60.082> to
<bitrate: 1128.21, SSIM: 26.607, PSNR: 60.093>

[8/33] testing x265-gcc old_town_cross_444_720p50.y4m --preset=fast
--keyint 20 --min-cu-size 16 -f50 --hash=1 --no-info
extras: --psnr --ssim ... FAIL
OUTPUT CHANGE: <bitrate: 1353.02, SSIM: 9.498, PSNR: 32.948> to
<bitrate: 1352.88, SSIM: 9.498, PSNR: 32.948>

the same test failures happen for Main10 encodes.

>  source/common/quant.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff -r bdee7c3b7853 -r ecf92b3cfb11 source/common/quant.cpp
> --- a/source/common/quant.cpp	Sun Apr 19 16:43:49 2015 +0800
> +++ b/source/common/quant.cpp	Sun Apr 19 16:44:04 2015 +0800
> @@ -938,7 +938,7 @@
>              cgRdStats.sigCost += costSig[scanPos];
>          } /* end for (scanPosinCG) */
>  
> -        X265_CHECK((cgScanPos << MLS_CG_SIZE) == scanPos, "scanPos mistake\n");
> +        X265_CHECK((cgScanPos << MLS_CG_SIZE) == (int)scanPos, "scanPos mistake\n");
>          cgRdStats.sigCost0 = costSig[scanPos];
>  
>          costCoeffGroupSig[cgScanPos] = 0;
> 
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel

-- 
Steve Borho