[x265] [PATCH 1 of 3] fix build fault on WinXP

Steve Borho steve at borho.org
Fri Apr 24 18:41:08 CEST 2015


On 04/24, Min Chen wrote:
> # HG changeset patch
> # User Min Chen <chenm003 at 163.com>
> # Date 1429883155 -28800
> # Node ID f942732ccf599452c00ce28e82b63e8d2d6e1b77
> # Parent  a35fafa25df2c82fec9e44d95f0a29ba835b48ea
> fix build fault on WinXP
> ---
>  source/CMakeLists.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff -r a35fafa25df2 -r f942732ccf59 source/CMakeLists.txt
> --- a/source/CMakeLists.txt	Thu Apr 23 12:32:49 2015 -0500
> +++ b/source/CMakeLists.txt	Fri Apr 24 21:45:55 2015 +0800
> @@ -305,7 +305,7 @@
>      if(WINXP_SUPPORT)
>          # force use of workarounds for CONDITION_VARIABLE and atomic
>          # intrinsics introduced after XP
> -        add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_WINXP)
> +        add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_WINXP -D_WIN32_WINNT_WIN7=0x0601)

Seems like it would be better to handle this as an #ifndef since most
are not building for XP natively, but that makes a nice chicken and egg
problem with Windows.h. sigh

>      else(WINXP_SUPPORT)
>          # default to targeting Windows 7 for the NUMA APIs
>          add_definitions(-D_WIN32_WINNT=_WIN32_WINNT_WIN7)
> 
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel

-- 
Steve Borho


More information about the x265-devel mailing list