[x265] [PATCH] add API and implementation for Region of Interest(ROI)

Steve Borho steve at borho.org
Fri Aug 7 20:19:37 CEST 2015


On 08/07, Deepthi Nandakumar wrote:
> Shall we copy quant offsets into inFrame within Encoder, so we dont need to
> worry about the user-handled x265_picture instances? Of course, inFrame
> will need to alloc/delete its own memory.
> 
> x264 uses callback free function pointers for all its structures (param,
> mb_info, quant_offsets) but we've not gone down this route yet (is there a
> good reason to?). Handling this the above way will keep it consistent with
> the way x265_picture::planes, analysis data etc are handled currently.

It's a compute overhead vs memory allocation trade-off. If we copied the
offsets before x265_encoder_encode() returned the application could use
a single offset buffer and we can forget about the callback function.
I'm ok with that trade-off.

-- 
Steve Borho


More information about the x265-devel mailing list