[x265] [PATCH] saoCuOrgE2: asm code

Steve Borho steve at borho.org
Mon Jan 5 15:16:00 CET 2015


On 01/05, Praveen Tiwari wrote:
> Locally no issue, investigating it. Is it for HBD ?

Only gcc and clang generally issue variable shadowing warnings

http://stackoverflow.com/questions/6225070/is-there-an-equivalent-of-gccs-wshadow-in-visual-c

> On Mon, Jan 5, 2015 at 5:46 PM, Steve Borho <steve at borho.org> wrote:
> 
> > On 01/05, praveen at multicorewareinc.com wrote:
> > > # HG changeset patch
> > > # User Praveen Tiwari
> > > # Date 1420458944 -19800
> > > # Node ID 132cbd77d7f149c3444a37a607567a875f27c229
> > > # Parent  cbdd7a2c3bf6d00a6b5379fedd0fb4de778e0a30
> > > saoCuOrgE2: asm code
> >
> > With the first and last of these 3 patches applied, I get these shadow
> > warnings:
> >
> > /Users/steve/repos/x265/source/encoder/sao.cpp:479:17: warning:
> > declaration shadows a local variable [-Wshadow]
> >             int x, y;
> >                 ^
> > /Users/steve/repos/x265/source/encoder/sao.cpp:227:9: note: previous
> > declaration is here
> >     int x, y;
> >         ^
> > /Users/steve/repos/x265/source/encoder/sao.cpp:479:20: warning:
> > declaration shadows a local variable [-Wshadow]
> >             int x, y;
> >                    ^
> > /Users/steve/repos/x265/source/encoder/sao.cpp:227:12: note: previous
> > declaration is here
> >     int x, y;
> >            ^
> > 2 warnings generated.

-- 
Steve Borho


More information about the x265-devel mailing list