[x265] v1.7+282: Multilib EXE doesn't link

[LigH]

Am 03.07.2015 21:12, schrieb Steve Borho:
> On 07/03, Mario *LigH* Rohkrämer wrote:
>> Both 8bit/libx265_main12.a and 8bit/libx265_main10.a do exist. Still,
>> linking to an EXE fails in an MSYS/MinGW environment, with either GCC 
>> 4.8.2
>> or GCC 4.9.2:
>> 
>> +----
>> [100%] Linking CXX executable x265.exe
>> x86_64-w64-mingw32-g++.exe: error: x265_main12: No such file or 
>> directory
>> make[2]: *** [x265.exe] Error 1
>> make[1]: *** [CMakeFiles/cli.dir/all] Error 2
>> make: *** [all] Error 2
>> +----
>> 
>> I believe that the submission of two distinct extra libraries to be 
>> linked
>> (-DEXTRA_LIB="x265_main10.a x265_main12.a") does not work as intended.
> 
> my bad, cmake needs a semicolon between those two libs. I fixed this 
> for
> linux and msvc but missed the msys script.

I am not sure how to generate a complete patch file out of a file change 
using Tortoise Hg (e.g. missing date and IDs); but this snippet should 
be sufficient to complete it with your requirements:

+----
# HG changeset patch
# User Mario Rohkrämer <contact at ligh.de>
# Date (???)
# Node ID (???)
# Parent  (???)
typo: extra libs to be linked in multilib must be separated by semicola, 
also for GCC in MSYS

diff -r 1162fb0b99f8 build/msys/multilib.sh
--- a/build/msys/multilib.sh	Fri Jul 03 13:43:47 2015 -0500
+++ b/build/msys/multilib.sh	Mon Jul 06 10:02:24 2015 +0200
@@ -13,5 +13,5 @@
  cp libx265.a ../8bit/libx265_main10.a

  cd ../8bit
-cmake -G "MSYS Makefiles" ../../../source -DEXPORT_C_API=OFF 
-DENABLE_SHARED=OFF -DENABLE_CLI=ON -DEXTRA_LIB="x265_main10.a 
x265_main12.a" -DEXTRA_LINK_FLAGS=-L.
+cmake -G "MSYS Makefiles" ../../../source -DEXPORT_C_API=OFF 
-DENABLE_SHARED=OFF -DENABLE_CLI=ON 
-DEXTRA_LIB="x265_main10.a;x265_main12.a" -DEXTRA_LINK_FLAGS=-L.
  make ${MAKEFLAGS}
+----