[x265] [PATCH] param: added x265_atof as internal encoder function, moved to namespace "X265_NS"

[Deepthi Nandakumar]

No, this is wrong.

What is the error you're tryning to fix? You probably need to reference
this function as X265_NS::x265_atof within x265-pcs.cpp.

On Fri, Jun 19, 2015 at 6:58 PM, <praveen at multicorewareinc.com> wrote:

> # HG changeset patch
> # User Praveen Tiwari <praveen at multicorewareinc.com>
> # Date 1434720481 -19800
> #      Fri Jun 19 18:58:01 2015 +0530
> # Node ID f53934a895e1ffc04edeae11183ad3556c09467b
> # Parent  44b6b2df7016f0129e66d91e9aab03261d02758a
> param: added x265_atof as internal encoder function, moved to namespace
> "X265_NS"
>
> diff -r 44b6b2df7016 -r f53934a895e1 source/common/param.cpp
> --- a/source/common/param.cpp   Fri Jun 19 16:43:29 2015 +0530
> +++ b/source/common/param.cpp   Fri Jun 19 18:58:01 2015 +0530
> @@ -471,16 +471,6 @@
>      return 0;
>  }
>
> -static double x265_atof(const char* str, bool& bError)
> -{
> -    char *end;
> -    double v = strtod(str, &end);
> -
> -    if (end == str || *end != '\0')
> -        bError = true;
> -    return v;
> -}
> -
>  static int parseName(const char* arg, const char* const* names, bool&
> bError)
>  {
>      for (int i = 0; names[i]; i++)
> @@ -890,6 +880,16 @@
>      return v;
>  }
>
> +double x265_atof(const char* str, bool& bError)
> +{
> +    char *end;
> +    double v = strtod(str, &end);
> +
> +    if (end == str || *end != '\0')
> +        bError = true;
> +    return v;
> +}
> +
>  /* cpu name can be:
>   *   auto || true - x265::cpu_detect()
>   *   false || no  - disabled
> diff -r 44b6b2df7016 -r f53934a895e1 source/common/param.h
> --- a/source/common/param.h     Fri Jun 19 16:43:29 2015 +0530
> +++ b/source/common/param.h     Fri Jun 19 18:58:01 2015 +0530
> @@ -2,6 +2,7 @@
>   * Copyright (C) 2013 x265 project
>   *
>   * Authors: Deepthi Nandakumar <deepthi at multicorewareinc.com>
> + *          Praveen Kumar Tiwari <praveen at multicorewareinc.com>
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
> @@ -33,6 +34,7 @@
>  void  x265_param_apply_fastfirstpass(x265_param *p);
>  char* x265_param2string(x265_param *param);
>  int   x265_atoi(const char *str, bool& bError);
> +double x265_atof(const char *str, bool& bError);
>  int   parseCpuName(const char *value, bool& bError);
>  void  setParamAspectRatio(x265_param *p, int width, int height);
>  void  getParamAspectRatio(x265_param *p, int& width, int& height);
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150619/1a25512e/attachment.html>