[x265] XP compatible x265_NS refactoring is incomplete

[Mario *LigH* Rohkrämer]

A lot of warnings in XP compatible Win32 builds with GCC 4.8.2 (here the  
HIGH_BIT_DEPTH setup, the 8-bit fails too):

+----
Scanning dependencies of target clean-generated
Built target clean-generated
-- cmake version 3.3.0-rc1
-- Detected x86 target processor
-- Found Yasm 1.3.0 to build assembly primitives
-- hg found at e:/Programme/TortoiseHg/hg.exe
-- x265 version 1.7+206-e8dc042008fa
-- Configuring done
-- Generating done
-- Build files have been written to:  
H:/MSYS/home/Entwicklung/x265/build/msys_hbd
Scanning dependencies of target common
[  1%] Building CXX object common/CMakeFiles/common.dir/winxp.cpp.obj
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,
                  from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:52:37: error:  
'x265_NS' does not name a type
  #define CONDITION_VARIABLE          x265_NS::ConditionVariable
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:211:5: note: in  
expansion of macro 'CONDITION_VARIABLE'
      CONDITION_VARIABLE m_cv;
      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In constructor  
'x265::ThreadSafeInteger::ThreadSafeInteger()':
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:53:37: error:  
'x265_NS' has not been declared
  #define InitializeConditionVariable x265_NS::cond_init
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:158:9: note: in  
expansion of macro 'InitializeConditionVariable'
          InitializeConditionVariable(&m_cv);
          ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:158:38: error:  
'm_cv' was not declared in this scope
          InitializeConditionVariable(&m_cv);
                                       ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,
                  from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In destructor  
'x265::ThreadSafeInteger::~ThreadSafeInteger()':
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:57:37: error:  
'x265_NS' has not been declared
  #define XP_CONDITION_VAR_FREE       x265_NS::cond_destroy
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:164:9: note: in  
expansion of macro 'XP_CONDITION_VAR_FREE'
          XP_CONDITION_VAR_FREE(&m_cv);
          ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:164:32: error:  
'm_cv' was not declared in this scope
          XP_CONDITION_VAR_FREE(&m_cv);
                                 ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,
                  from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member  
function 'int x265::ThreadSafeInteger::waitForChange(int)':
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:54:37: error:  
'x265_NS' has not been declared
  #define SleepConditionVariableCS    x265_NS::cond_wait
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:171:13: note: in  
expansion of macro 'SleepConditionVariableCS'
              SleepConditionVariableCS(&m_cv, &m_cs, INFINITE);
              ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:171:39: error:  
'm_cv' was not declared in this scope
              SleepConditionVariableCS(&m_cv, &m_cs, INFINITE);
                                        ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,
                  from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member  
function 'void x265::ThreadSafeInteger::set(int)':
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:56:37: error:  
'x265_NS' has not been declared
  #define WakeAllConditionVariable    x265_NS::cond_broadcast
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:188:9: note: in  
expansion of macro 'WakeAllConditionVariable'
          WakeAllConditionVariable(&m_cv);
          ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:188:35: error:  
'm_cv' was not declared in this scope
          WakeAllConditionVariable(&m_cv);
                                    ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,
                  from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member  
function 'void x265::ThreadSafeInteger::poke()':
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:56:37: error:  
'x265_NS' has not been declared
  #define WakeAllConditionVariable    x265_NS::cond_broadcast
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:196:9: note: in  
expansion of macro 'WakeAllConditionVariable'
          WakeAllConditionVariable(&m_cv);
          ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:196:35: error:  
'm_cv' was not declared in this scope
          WakeAllConditionVariable(&m_cv);
                                    ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:32:0,
                  from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h: In member  
function 'void x265::ThreadSafeInteger::incr()':
h:/MSYS/home/Entwicklung/x265/source/common/winxp.h:56:37: error:  
'x265_NS' has not been declared
  #define WakeAllConditionVariable    x265_NS::cond_broadcast
                                      ^
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:204:9: note: in  
expansion of macro 'WakeAllConditionVariable'
          WakeAllConditionVariable(&m_cv);
          ^
In file included from  
h:/MSYS/home/Entwicklung/x265/source/common/winxp.cpp:24:0:
h:/MSYS/home/Entwicklung/x265/source/common/threading.h:204:35: error:  
'm_cv' was not declared in this scope
          WakeAllConditionVariable(&m_cv);
                                    ^
make[2]: *** [common/CMakeFiles/common.dir/winxp.cpp.obj] Error 1
make[1]: *** [common/CMakeFiles/common.dir/all] Error 2
make: *** [all] Error 2
+----

-- 

Fun and success!
Mario *LigH* Rohkrämer
mailto:contact at ligh.de