[x265] XP compatible x265_NS refactoring is incomplete

[Stephen Hutchinson]

On Mon, Jun 22, 2015 at 5:46 AM, Deepthi Nandakumar
<deepthi at multicorewareinc.com> wrote:
> I don't think the second error that was reported on XP with no-assembly has
> been fixed.
>

Actually, the second part of issue #146 isn't Windows-specific at all,
XP support enabled or not.
It happens with any 32-bit build, even native Linux ones, in that when
EXPORT_C_API is false,
HIGH_BIT_DEPTH is true, and assembly is disabled, this happens:

[28/51] Building CXX object common/CMakeFiles/common.dir/cpu.cpp.obj
FAILED: /usr/bin/i686-w64-mingw32-g++   -DEXPORT_C_API=0
-DHAVE_INT_TYPES_H=1 -DHIGH_BIT_DEPTH=1 -DX265_ARCH_X86=1
-DX265_NS=x265_10bpp -D_WIN32_WINNT=_WIN32_WINNT_WIN7
-D__STDC_LIMIT_MACROS=1 -mfpmath=sse -march=pentium3 -msse
-mtune=pentium3 -O3 -DNDEBUG -I/home/qyot27/x265-build/x265/source/.
-I/home/qyot27/x265-build/x265/source/common
-I/home/qyot27/x265-build/x265/source/encoder -I.    -Wall -Wextra
-Wshadow -march=i686 -Wno-array-bounds -ffast-math -mstackrealign
-fno-exceptions -Wno-narrowing -MMD -MT
common/CMakeFiles/common.dir/cpu.cpp.obj -MF
common/CMakeFiles/common.dir/cpu.cpp.obj.d -o
common/CMakeFiles/common.dir/cpu.cpp.obj -c
/home/qyot27/x265-build/x265/source/common/cpu.cpp
/home/qyot27/x265-build/x265/source/common/cpu.cpp: In function
'uint32_t x265_10bpp::cpu_detect()':
/home/qyot27/x265-build/x265/source/common/cpu.cpp:128:30: error:
'x265_cpu_cpuid_test' was not declared in this scope
     if (!x265_cpu_cpuid_test())
                              ^
[28/51] Building CXX object common/CMakeFiles/common.dir/ipfilter.cpp.obj
ninja: build stopped: subcommand failed.

For all I know it might even happen with the 32-bit 8bit builds if
EXPORT_C_API is false and
asm is disabled, but I have no need to do that so I haven't checked.

HIGH_BIT_DEPTH 32-bit builds aren't recommended, but the only thing
causing a build failure
is when you try to use EXPORT_C_API:bool=false in order to do
static-multilib.  Shared-multilib
or static no-multilib builds are unaffected.