[x265] [PATCH] slicetype: fix crash when rc-lookahead = bframes

[Deepthi Nandakumar]

Right - thats what I meant bframes >= lookaheadDepth.

On Mon, Mar 9, 2015 at 9:36 PM, Aarthi Priya Thirumalai <
aarthi at multicorewareinc.com> wrote:

> crash occurs when lookaheadDepth equals bframes.
> need to modify it CHECK(param->bframes >*=* param->lookaheadDepth
>
> On Mon, Mar 9, 2015 at 9:18 PM, Steve Borho <steve at borho.org> wrote:
>
>> On 03/09, Deepthi Nandakumar wrote:
>> > slicetypeAnalyse::maxSearch also needs to be changed, or you could
>> trigger
>> > another crash using --b-adapt 1.
>> >
>> > It seems to me, under the hood we're just incrementing lookaheadDepth.
>> That
>> > may be the right thing to do here, or do a CHECK for lookaheadDepth >=
>> > bframes?
>>
>> We have:
>>
>> CHECK(param->bframes > param->lookaheadDepth && !param->rc.bStatRead,
>>       "Lookahead depth must be greater than the max consecutive bframe
>> count");
>>
>> is this not sufficient?
>>
>> --
>> Steve Borho
>> _______________________________________________
>> x265-devel mailing list
>> x265-devel at videolan.org
>> https://mailman.videolan.org/listinfo/x265-devel
>>
>
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150309/41adb807/attachment.html>