[x265] [PATCH] Add missing parameters in SEI: rdoq & deblock

[Tom Vaughan]

Hey Steve... I just gave a different answer on Doom9...
http://forum.doom9.org/showthread.php?p=1714826#post1714826

-----Original Message-----
From: x265-devel [mailto:x265-devel-bounces at videolan.org] On Behalf Of
Steve Borho
Sent: Thursday, March 26, 2015 6:27 PM
To: Development for x265
Subject: Re: [x265] [PATCH] Add missing parameters in SEI: rdoq & deblock

On 03/26, Xinyue Lu wrote:
> Hi all,
>
> I'm new to the mail list. Please let me know if I did anything wrong.
> Thanks.
>
> This patch is put into public domain by author, to avoid any copyright
> etc problems.

Thanks, this patch Looks pretty good except for the commit username.  We
prefer something like: "First Last <you at email.com>" that way you get full
attribution in the revision history.

I can fix up the username if you're ok with using the email you sent the
patch from, but there is also the matter of the contributor license
agreement.  See https://bitbucket.org/multicoreware/x265/wiki/Contribute
We need that filled out and signed before we can accept your first patch.
Fortunately it only needs to be done once.

> # HG changeset patch
> # User msg7086 <i at 7086.in>
> # Date 1427412793 25200
> #      Thu Mar 26 16:33:13 2015 -0700
> # Node ID 759c7031bb4ebce18e632fb1daf7ebf4733e666b
> # Parent  dc7a6c5fbda13173004e6193f185ea857d7a22c8
> param: add missing parameters in sei
>
> diff -r dc7a6c5fbda1 -r 759c7031bb4e source/common/param.cpp
> --- a/source/common/param.cpp Thu Mar 26 11:24:23 2015 -0500
> +++ b/source/common/param.cpp Thu Mar 26 16:33:13 2015 -0700
> @@ -1383,6 +1383,7 @@
>      s += sprintf(s, " crqpoffs=%d", p->crQpOffset);
>      s += sprintf(s, " rd=%d", p->rdLevel);
>      s += sprintf(s, " psy-rd=%.2f", p->psyRd);
> +    s += sprintf(s, " rdoq=%d", p->rdoqLevel);
>      s += sprintf(s, " psy-rdoq=%.2f", p->psyRdoq);
>      BOOL(p->bEnableSignHiding, "signhide");
>      BOOL(p->bEnableLoopFilter, "lft"); @@ -1420,6 +1421,12 @@
>          if (p->bframes)
>              s += sprintf(s, " pbratio=%.2f", p->rc.pbFactor);
>      }
> +    if (p->bEnableLoopFilter)
> +    {
> +        BOOL(true, "deblock");
> +        if (p->deblockingFilterBetaOffset ||
p->deblockingFilterTCOffset)
> +            s += sprintf(s, "=%d:%d", p->deblockingFilterTCOffset,
> p->deblockingFilterBetaOffset);
> +    }
>  #undef BOOL
>      return buf;
>  }
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel

--
Steve Borho
_______________________________________________
x265-devel mailing list
x265-devel at videolan.org
https://mailman.videolan.org/listinfo/x265-devel