[x265] [PATCH 16 of 16] asm: improve sao stats compute by SIMD

Steve Borho steve at borho.org
Wed Oct 7 18:49:15 CEST 2015


On 10/07, chen wrote:
> in IACA report, just ~3 cycles

I think Pradeep meant for the whole series of patches

> At 2015-10-07 16:49:24,"Pradeep Ramachandran" <pradeep at multicorewareinc.com> wrote:
> 
> Min,
> Do you see a performance improvement through this sequence of patches? 
> 
> 
> Pradeep Ramachandran, PhD
> Solution Architect,
> pradeeprama.info/
> www.multicorewareinc.com/
> Ph:   +91 99627 82018
> 
> 
> On Wed, Oct 7, 2015 at 4:25 AM, Min Chen <chenm003 at 163.com> wrote:
> # HG changeset patch
> # User Min Chen <chenm003 at 163.com>
> # Date 1444170873 18000
> # Node ID f2158e8c15efde0991cb06033399e9256f54ad7e
> # Parent  36a54b2cf7c4c96067bafb67077651d30d83e8e9
> asm: improve sao stats compute by SIMD
> ---
>  source/common/x86/loopfilter.asm |  124 +++++++++++++++-----------------------
>  1 files changed, 49 insertions(+), 75 deletions(-)
> 
> diff -r 36a54b2cf7c4 -r f2158e8c15ef source/common/x86/loopfilter.asm
> --- a/source/common/x86/loopfilter.asm  Tue Oct 06 16:42:06 2015 -0500
> +++ b/source/common/x86/loopfilter.asm  Tue Oct 06 17:34:33 2015 -0500
> @@ -2112,25 +2112,19 @@
>      mov         r0, r6mp
> 
>      ; s_eoTable = {1, 2, 0, 3, 4}
> -    movzx       r5d, word [rsp + 0 * 2]
> -    add         [r0 + 1 * 4], r5d
> -    movzx       r6d, word [rsp + 1 * 2]
> -    add         [r0 + 2 * 4], r6d
> -    movzx       r5d, word [rsp + 2 * 2]
> -    add         [r0 + 0 * 4], r5d
> -    movzx       r6d, word [rsp + 3 * 2]
> -    add         [r0 + 3 * 4], r6d
> +    pmovzxwd    m0, [rsp + 0 * 2]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r0]
> +    paddd       m0, m1
> +    movu        [r0], m0
>      movzx       r5d, word [rsp + 4 * 2]
>      add         [r0 + 4 * 4], r5d
> 
> -    mov         r6d, [rsp + 5 * 2 + 0 * 4]
> -    add         [r9 + 1 * 4], r6d
> -    mov         r5d, [rsp + 5 * 2 + 1 * 4]
> -    add         [r9 + 2 * 4], r5d
> -    mov         r6d, [rsp + 5 * 2 + 2 * 4]
> -    add         [r9 + 0 * 4], r6d
> -    mov         r5d, [rsp + 5 * 2 + 3 * 4]
> -    add         [r9 + 3 * 4], r5d
> +    movu        m0, [rsp + 5 * 2 + 0 * 4]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r9]
> +    paddd       m0, m1
> +    movu        [r9], m0
>      mov         r6d, [rsp + 5 * 2 + 4 * 4]
>      add         [r9 + 4 * 4], r6d
>      RET
> @@ -2219,25 +2213,19 @@
>      mov         r0, r7m
> 
>      ; s_eoTable = {1,2,0,3,4}
> -    movzx       r6d, word [rsp + 0 * 2]
> -    add         [r0 + 1 * 4], r6d
> -    movzx       r6d, word [rsp + 1 * 2]
> -    add         [r0 + 2 * 4], r6d
> -    movzx       r6d, word [rsp + 2 * 2]
> -    add         [r0 + 0 * 4], r6d
> -    movzx       r6d, word [rsp + 3 * 2]
> -    add         [r0 + 3 * 4], r6d
> -    movzx       r6d, word [rsp + 4 * 2]
> -    add         [r0 + 4 * 4], r6d
> -
> -    mov         r6d, [rsp + 5 * 2 + 0 * 4]
> -    add         [r1 + 1 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 1 * 4]
> -    add         [r1 + 2 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 2 * 4]
> -    add         [r1 + 0 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 3 * 4]
> -    add         [r1 + 3 * 4], r6d
> +    pmovzxwd    m0, [rsp + 0 * 2]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r0]
> +    paddd       m0, m1
> +    movu        [r0], m0
> +    movzx       r5d, word [rsp + 4 * 2]
> +    add         [r0 + 4 * 4], r5d
> +
> +    movu        m0, [rsp + 5 * 2 + 0 * 4]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r1]
> +    paddd       m0, m1
> +    movu        [r1], m0
>      mov         r6d, [rsp + 5 * 2 + 4 * 4]
>      add         [r1 + 4 * 4], r6d
>      RET
> @@ -2379,33 +2367,25 @@
>      mov         r0, r8m
> 
>      ; s_eoTable = {1,2,0,3,4}
> -    movzx       r6d, word [rsp + 0 * 2]
> -    add         [r0 + 1 * 4], r6d
> -    movzx       r6d, word [rsp + 1 * 2]
> -    add         [r0 + 2 * 4], r6d
> -    movzx       r6d, word [rsp + 2 * 2]
> -    add         [r0 + 0 * 4], r6d
> -    movzx       r6d, word [rsp + 3 * 2]
> -    add         [r0 + 3 * 4], r6d
> -    movzx       r6d, word [rsp + 4 * 2]
> -    add         [r0 + 4 * 4], r6d
> -
> -    mov         r6d, [rsp + 5 * 2 + 0 * 4]
> -    add         [r1 + 1 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 1 * 4]
> -    add         [r1 + 2 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 2 * 4]
> -    add         [r1 + 0 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 3 * 4]
> -    add         [r1 + 3 * 4], r6d
> +    pmovzxwd    m0, [rsp + 0 * 2]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r0]
> +    paddd       m0, m1
> +    movu        [r0], m0
> +    movzx       r5d, word [rsp + 4 * 2]
> +    add         [r0 + 4 * 4], r5d
> +
> +    movu        m0, [rsp + 5 * 2 + 0 * 4]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r1]
> +    paddd       m0, m1
> +    movu        [r1], m0
>      mov         r6d, [rsp + 5 * 2 + 4 * 4]
>      add         [r1 + 4 * 4], r6d
>      RET
>  %endif ; ARCH_X86_64
> 
> 
> -
> -
>  ;void saoStatE3(const int16_t *diff, const pixel *rec, intptr_t stride, int8_t *upBuff1, int endX, int endY, int32_t *stats, int32_t *count);
>  ;{
>  ;    memset(tmp_stats, 0, sizeof(tmp_stats));
> @@ -2520,25 +2500,19 @@
>      mov         r0, r7m
> 
>      ; s_eoTable = {1,2,0,3,4}
> -    movzx       r6d, word [rsp + 0 * 2]
> -    add         [r0 + 1 * 4], r6d
> -    movzx       r6d, word [rsp + 1 * 2]
> -    add         [r0 + 2 * 4], r6d
> -    movzx       r6d, word [rsp + 2 * 2]
> -    add         [r0 + 0 * 4], r6d
> -    movzx       r6d, word [rsp + 3 * 2]
> -    add         [r0 + 3 * 4], r6d
> -    movzx       r6d, word [rsp + 4 * 2]
> -    add         [r0 + 4 * 4], r6d
> -
> -    mov         r6d, [rsp + 5 * 2 + 0 * 4]
> -    add         [r1 + 1 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 1 * 4]
> -    add         [r1 + 2 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 2 * 4]
> -    add         [r1 + 0 * 4], r6d
> -    mov         r6d, [rsp + 5 * 2 + 3 * 4]
> -    add         [r1 + 3 * 4], r6d
> +    pmovzxwd    m0, [rsp + 0 * 2]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r0]
> +    paddd       m0, m1
> +    movu        [r0], m0
> +    movzx       r5d, word [rsp + 4 * 2]
> +    add         [r0 + 4 * 4], r5d
> +
> +    movu        m0, [rsp + 5 * 2 + 0 * 4]
> +    pshufd      m0, m0, q3102
> +    movu        m1, [r1]
> +    paddd       m0, m1
> +    movu        [r1], m0
>      mov         r6d, [rsp + 5 * 2 + 4 * 4]
>      add         [r1 + 4 * 4], r6d
>      RET
> 
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
> 
> 

> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel


-- 
Steve Borho


More information about the x265-devel mailing list