[x265] GCC warnings for Win32 target of threadpool.cpp: unused parameter [numa]nodeMask

[Pradeep Ramachandran]

I've sent a patch to the mailing list that should fix this compile time
warning.

Pradeep Ramachandran, PhD
Solution Architect,
Multicoreware Inc.
Ph:   +91 99627 82018

On Tue, Sep 8, 2015 at 11:44 AM, Mario *LigH* Rohkrämer <contact at ligh.de>
wrote:

> This is a compiler warning from GCC, not from the running x265.exe.
>
> My Win32 builds are flagged as XP compatible in addition, that's probably
> the reason to compile some legacy code instead of calling Vista+ OS
> functions...
>
>
>
>
> Am 07.09.2015, 18:03 Uhr, schrieb Pradeep Ramachandran <
> pradeep at multicorewareinc.com>:
>
> Hmm... in both these functions, the nodeMask (or numaNodeMask) parameter
>> isn't used if _WIN32_WINNT >= _WIN32_WINNT_WIN7 evaluates to false. What
>> version of Windows are you running this on?
>>
>> I tried a 32-bit Windows build on Windows 8.1 and GCC 4.9.X and don't see
>> any such warning.
>>
>> Pradeep Ramachandran, PhD
>> Solution Architect,
>> Multicoreware Inc.
>> Ph:   +91 99627 82018
>>
>> On Mon, Sep 7, 2015 at 5:50 PM, Mario *LigH* Rohkrämer <contact at ligh.de>
>> wrote:
>>
>> Win64 target has no warning; Win32 target compiles with GCC 4.9.2 or 5.2.0
>>> report:
>>>
>>> +----
>>> [ 60%] Building CXX object
>>> common/CMakeFiles/common.dir/threadpool.cpp.obj
>>> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/threadpool.cpp:376:68:
>>> warning: unused parameter 'nodeMask' [-Wunused-parameter]
>>>  bool ThreadPool::create(int numThreads, int maxProviders, uint32_t
>>> nodeMask)
>>>                                                                     ^
>>> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/threadpool.cpp:463:46:
>>> warning: unused parameter 'numaNodeMask' [-Wunused-parameter]
>>>  void ThreadPool::setThreadNodeAffinity(void *numaNodeMask)
>>>                                               ^
>>> +----
>>>
>>> --
>>>
>>> Fun and success!
>>> Mario *LigH* Rohkrämer
>>> mailto:contact at ligh.de
>>>
>>> _______________________________________________
>>> x265-devel mailing list
>>> x265-devel at videolan.org
>>> https://mailman.videolan.org/listinfo/x265-devel
>>>
>>>
>
> --
>
> Fun and success!
> Mario *LigH* Rohkrämer
> mailto:contact at ligh.de
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150908/32492ed1/attachment.html>