[x265] Warnings in 12-bit code: right shift count is negative

Deepthi Nandakumar deepthi at multicorewareinc.com
Thu Sep 24 10:50:00 CEST 2015


Thanks for reporting, this is an open issue on Bitbucket under
investigation.

On Thu, Sep 24, 2015 at 9:57 AM, Mario *LigH* Rohkrämer <contact at ligh.de>
wrote:

> +----
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp: In
> instantiation of 'uint32_t x265::Quant::rdoQuant(const x265::CUData&,
> int16_t*, x265::TextType, uint32_t, bool) [with unsigned int log2TrSize =
> 4u; uint32_t = unsigned int; int16_t = short int]':
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:189:139:
>  required from here
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:672:48: note:
> in expansion of macro 'PSYVALUE'
>                      costUncoded[blkPos + x] -= PSYVALUE(predictedCoef);
>                                                 ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:779:52: note:
> in expansion of macro 'PSYVALUE'
>                          costUncoded[blkPos + x] -=
> PSYVALUE(predictedCoef);
>                                                     ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:857:40: note:
> in expansion of macro 'PSYVALUE'
>                  costUncoded[blkPos] -= PSYVALUE(predictedCoef);
>                                         ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:940:36: note:
> in expansion of macro 'PSYVALUE'
>                          curCost -= PSYVALUE(reconCoef);
>                                     ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:968:37: note:
> in expansion of macro 'PSYVALUE'
>                          curCost0 -= PSYVALUE(reconCoef);
>                                      ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:971:37: note:
> in expansion of macro 'PSYVALUE'
>                          curCost1 -= PSYVALUE(reconCoef);
>                                      ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp: In
> instantiation of 'uint32_t x265::Quant::rdoQuant(const x265::CUData&,
> int16_t*, x265::TextType, uint32_t, bool) [with unsigned int log2TrSize =
> 5u; uint32_t = unsigned int; int16_t = short int]':
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:189:139:
>  required from here
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:672:48: note:
> in expansion of macro 'PSYVALUE'
>                      costUncoded[blkPos + x] -= PSYVALUE(predictedCoef);
>                                                 ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:779:52: note:
> in expansion of macro 'PSYVALUE'
>                          costUncoded[blkPos + x] -=
> PSYVALUE(predictedCoef);
>                                                     ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:857:40: note:
> in expansion of macro 'PSYVALUE'
>                  costUncoded[blkPos] -= PSYVALUE(predictedCoef);
>                                         ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:940:36: note:
> in expansion of macro 'PSYVALUE'
>                          curCost -= PSYVALUE(reconCoef);
>                                     ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:968:37: note:
> in expansion of macro 'PSYVALUE'
>                          curCost0 -= PSYVALUE(reconCoef);
>                                      ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:592:45:
> warning: right shift count is negative
>  #define PSYVALUE(rec)   ((psyScale * (rec)) >> (2 * transformShift + 1))
>                                              ^
> h:/MSYS-GCC492/home/Entwicklung/x265/source/common/quant.cpp:971:37: note:
> in expansion of macro 'PSYVALUE'
>                          curCost1 -= PSYVALUE(reconCoef);
>                                      ^
> +----
>
> --
>
> Fun and success!
> Mario *LigH* Rohkrämer
> mailto:contact at ligh.de
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150924/7d06d7a1/attachment-0001.html>


More information about the x265-devel mailing list