[x265] [PATCH] asm: rearrange buffer positions to align m_residualSumEmergency buffer for asm code

[chen]

move not enough, we can't assume all struct aligned to specially byte address



At 2015-09-28 23:03:37,"Deepthi Nandakumar" <deepthi at multicorewareinc.com> wrote:


Agreed, if you move the array all the way to the top, you will be better off.

On 28-Sep-2015 8:20 pm, "chen" <chenm003 at 163.com> wrote:

this is unsafe way to make alignment buffer , it depends on Compiler and its version


At 2015-09-28 12:43:12,dnyaneshwar at multicorewareinc.com wrote:
># HG changeset patch
># User Dnyaneshwar G <dnyaneshwar at multicorewareinc.com>
># Date 1443415172 -19800
>#      Mon Sep 28 10:09:32 2015 +0530
># Node ID 247891a7dbea7ae2a0e89c290b5a35f38d5be658
># Parent  4f524673358748837d281abf28e4382f2ee845d2
>asm: rearrange buffer positions to align m_residualSumEmergency buffer for asm code
>
>diff -r 4f5246733587 -r 247891a7dbea source/encoder/encoder.h
>--- a/source/encoder/encoder.h	Thu Sep 24 18:53:28 2015 -0500
>+++ b/source/encoder/encoder.h	Mon Sep 28 10:09:32 2015 +0530
>@@ -131,8 +131,8 @@
>     bool               m_aborted;          // fatal error detected
>     bool               m_reconfigured;      // reconfigure of encoder detected
> 
>+    uint16_t           (*m_offsetEmergency)[MAX_NUM_TR_CATEGORIES][MAX_NUM_TR_COEFFS];
>     uint32_t           m_residualSumEmergency[MAX_NUM_TR_CATEGORIES][MAX_NUM_TR_COEFFS];
>-    uint16_t           (*m_offsetEmergency)[MAX_NUM_TR_CATEGORIES][MAX_NUM_TR_COEFFS];
>     uint32_t           m_countEmergency[MAX_NUM_TR_CATEGORIES];
> 
>     Encoder();
>_______________________________________________
>x265-devel mailing list
>x265-devel at videolan.org
>https://mailman.videolan.org/listinfo/x265-devel

_______________________________________________
x265-devel mailing list
x265-devel at videolan.org
https://mailman.videolan.org/listinfo/x265-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20150928/c1061493/attachment.html>