[x265] [PATCH] SSIM based RDO for mode selection

[Pradeep Ramachandran]

On Thu, Dec 29, 2016 at 11:01 PM, Mario Rohkrämer <contact at ligh.de> wrote:

> Am 28.12.2016, 16:11 Uhr, schrieb <ashok at multicorewareinc.com>:
>
> diff -r af10eaeb36cd -r 146036b4049c source/x265cli.h
>> --- a/source/x265cli.h  Wed Dec 28 10:17:08 2016 +0530
>> +++ b/source/x265cli.h  Wed Dec 28 19:12:02 2016 +0530
>> @@ -256,6 +256,8 @@
>>      { "analyze-src-pics", no_argument, NULL, 0 },
>>      { "no-analyze-src-pics", no_argument, NULL, 0 },
>>      { "slices",         required_argument, NULL, 0 },
>> +    { "ssim-rd",      no_argument, NULL, 0 },
>> +    { "no-ssim-rd",   no_argument, NULL, 0 },
>>      { 0, 0, 0, 0 },
>>      { 0, 0, 0, 0 },
>>      { 0, 0, 0, 0 },
>> @@ -340,6 +342,7 @@
>>      H0("   --[no-]psy-rd <0..5.0>        Strength of psycho-visual rate
>> distortion optimization, 0 to disable. Default %.1f\n", param->psyRd);
>>      H0("   --[no-]rdoq-level <0|1|2>     Level of RDO in quantization
>> 0:none, 1:levels, 2:levels & coding groups. Default %d\n",
>> param->rdoqLevel);
>>      H0("   --[no-]psy-rdoq <0..50.0>     Strength of psycho-visual
>> optimization in RDO quantization, 0 to disable. Default %.1f\n",
>> param->psyRdoq);
>> +    H0("   --[no-]ssim-rd                Enable ssim rate distortion
>> optimization, 0 to disable. Default %.1f\n", OPT(param->bSsimRd));
>>      H0("   --[no-]rd-refine              Enable QP based RD refinement
>> for rd levels 5 and 6. Default %s\n", OPT(param->bEnableRdRefine));
>>      H0("   --[no-]early-skip             Enable early SKIP detection.
>> Default %s\n", OPT(param->bEnableEarlySkip));
>>      H0("   --[no-]rskip                  Enable early exit from
>> recursion. Default %s\n", OPT(param->bEnableRecursionSkip));
>>
>
>
> Copy/paste mistake? May be another case of default "disabled", where the
> CLI option has no argument, only the negation prefix (so "0 to disable" is
> already misleading IMHO; but I don't know if there will be several levels
> in the future, beyond 0=off/1=on).
>

Copy-paste mistake. Have pushed patches to fix this (and another warning
from rdcost.h).


>
> +----
> In file included from h:/MSYS-GCC620/home/LigH/x265/source/x265.cpp:30:0:
> h:/MSYS-GCC620/home/LigH/x265/source/x265cli.h: In function 'void
> x265::showHelp(x265_param*)':
> h:/MSYS-GCC620/home/LigH/x265/source/x265cli.h:347:134: warning: format
> '%f' expects argument of type 'double', but argument 2 has type 'const
> char*' [-Wformat=]
>        H0("   --[no-]ssim-rd                Enable ssim rate distortion
> optimization, 0 to disable. Default %.1f\n", OPT(param->bSsimRd));
>
>                                                               ^
> +----
>
> --
>
> Fun and success!
> Mario *LigH* Rohkrämer
> mailto:contact at ligh.de
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20161230/fb5e8e61/attachment-0001.html>