[x265] [PATCH] threadpool: fix warning: ‘int popCount(uint64_t)’ defined but not used [-Wunused-function]

[Praveen Tiwari]

I remember some numa functionality requires minimum window 7, they are not
supported on previous version of window OS.

Regards,
Praveen

On Mon, May 30, 2016 at 6:43 PM, Mateusz <mateuszb at poczta.onet.pl> wrote:

> There is a serious bug in threadpool code that prevent working in Windows
> XP/Vista.
> VS 2015 error when compiling for 32-bit Windows XP:
> (ClCompile target) ->
>   I:\vs\x265\source\common\threadpool.cpp(590): error C3861:
> 'GetNumaNodeProcessorMaskEx': identifier not found [I:\vs\x265\ma\
> 8-b\common\common.vcxproj]
>
> Did you see patch https://patches.videolan.org/patch/13495/ (it fixes
> also this warning)?
>
>
> W dniu 2016-05-30 o 14:45, praveen at multicorewareinc.com pisze:
> > # HG changeset patch
> > # User Praveen Tiwari <praveen at multicorewareinc.com>
> > # Date 1464585837 -19800
> > #      Mon May 30 10:53:57 2016 +0530
> > # Node ID b8dbe8d7c09e7fc0b7cce236569fc5df2eb70b1e
> > # Parent  aeade2e8d8688ebffb8455b8948d89d6a72e2c38
> > threadpool: fix warning: ‘int popCount(uint64_t)’ defined but not used
> [-Wunused-function]
> >  static int popCount(uint64_t x)
> >
> > diff -r aeade2e8d868 -r b8dbe8d7c09e source/common/threadpool.cpp
> > --- a/source/common/threadpool.cpp    Thu May 26 16:45:09 2016 +0530
> > +++ b/source/common/threadpool.cpp    Mon May 30 10:53:57 2016 +0530
> > @@ -68,6 +68,7 @@
> >  # define strcasecmp _stricmp
> >  #endif
> >
> > +#if defined(_WIN32_WINNT) && _WIN32_WINNT >= _WIN32_WINNT_WIN7
> >  const uint64_t m1 = 0x5555555555555555; //binary: 0101...
> >  const uint64_t m2 = 0x3333333333333333; //binary: 00110011..
> >  const uint64_t m3 = 0x0f0f0f0f0f0f0f0f; //binary:  4 zeros,  4 ones ...
> > @@ -80,6 +81,7 @@
> >      x = (x + (x >> 4)) & m3;
> >      return (x * h01) >> 56;
> >  }
> > +#endif
> >
> >  namespace X265_NS {
> >  // x265 private namespace
> >
> >
> >
> > _______________________________________________
> > x265-devel mailing list
> > x265-devel at videolan.org
> > https://mailman.videolan.org/listinfo/x265-devel
> >
>
>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20160530/f3f53d77/attachment.html>