[x265] [PATCH] cli: add new option '--fullhelp'

[Mateusz]

W dniu 03.12.2017 o 22:01, Ashok Kumar Mishra pisze:
> We have similar command line --help. Can you help me understand the purpose of introducing new command line --fullhelp.

'--help' shows short list, '--log-level full --help' shows full list but is hard to remember and hard to write.

'--fullhelp' shows full list and it is easy to remember and write (== '--log-level full --help').

In x264 there are 3 help levels:
--help
--longhelp
--fullhelp


> On Thu, Nov 30, 2017 at 11:00 PM, Ma0 <mateuszb at poczta.onet.pl <mailto:mateuszb at poczta.onet.pl>> wrote:
> 
>     # HG changeset patch
>     # User Ma0 <mateuszb at poczta.onet.pl <mailto:mateuszb at poczta.onet.pl>>
>     # Date 1512062959 -3600
>     #      Thu Nov 30 18:29:19 2017 +0100
>     # Node ID eb984fafe55d6382d67d5b98897cf5b88179616f
>     # Parent  b1dfa312234ed72c3541831a15f307feaf79484d
>     cli: add new option '--fullhelp'
> 
>     diff -r b1dfa312234e -r eb984fafe55d source/x265.cpp
>     --- a/source/x265.cpp   Thu Nov 30 10:06:49 2017 +0530
>     +++ b/source/x265.cpp   Thu Nov 30 18:29:19 2017 +0100
>     @@ -301,6 +301,13 @@
>                      if (!this->qpfile)
>                          x265_log_file(param, X265_LOG_ERROR, "%s qpfile not found or error in opening qp file\n", optarg);
>                  }
>     +            OPT("fullhelp")
>     +            {
>     +                param->logLevel = X265_LOG_FULL;
>     +                printVersion(param, api);
>     +                showHelp(param);
>     +                break;
>     +            }
>                  else
>                      bError |= !!api->param_parse(param, long_options[long_options_index].name, optarg);
> 
>     diff -r b1dfa312234e -r eb984fafe55d source/x265cli.h
>     --- a/source/x265cli.h  Thu Nov 30 10:06:49 2017 +0530
>     +++ b/source/x265cli.h  Thu Nov 30 18:29:19 2017 +0100
>     @@ -38,6 +38,7 @@
>      static const struct option long_options[] =
>      {
>          { "help",                 no_argument, NULL, 'h' },
>     +    { "fullhelp",             no_argument, NULL, 0 },
>          { "version",              no_argument, NULL, 'V' },
>          { "asm",            required_argument, NULL, 0 },
>          { "no-asm",               no_argument, NULL, 0 },
>     @@ -314,6 +315,7 @@
>          H0("    outfile is raw HEVC bitstream\n");
>          H0("\nExecutable Options:\n");
>          H0("-h/--help                        Show this help text and exit\n");
>     +    H0("   --fullhelp                    Show all options and exit\n");
>          H0("-V/--version                     Show version info and exit\n");
>          H0("\nOutput Options:\n");
>          H0("-o/--output <filename>           Bitstream output file name\n");
>     @@ -565,7 +567,7 @@
>      #undef H1
> 
>          if (level < X265_LOG_DEBUG)
>     -        printf("\nUse --log-level full --help for a full listing\n");
>     +        printf("\nUse --fullhelp for a full listing (or --log-level full --help)\n");
>          printf("\n\nComplete documentation may be found at http://x265.readthedocs.org/en/default/cli.html\n <http://x265.readthedocs.org/en/default/cli.html\n>");
>          exit(1);
>      }
>     _______________________________________________
>     x265-devel mailing list
>     x265-devel at videolan.org <mailto:x265-devel at videolan.org>
>     https://mailman.videolan.org/listinfo/x265-devel <https://mailman.videolan.org/listinfo/x265-devel>
> 
> 
> 
> 
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>