[x265] dynamicHDR10 branch probably not cleaned?

[Mario *LigH* Rohkrämer]

I mean "make clean-generated", not "make clean".

I am not sure which difference between them is intended. All I can tell is  
that executing the sequence

	make clean-generated
	make

rebuilds all the sub-targets ("encoder", "common", "cli") apparently  
completely, only the sub-target "dynamicHDR10" seems to build only changed  
files; you can see that ~5% are skipped. So I wonder if either CMake  
builds too little for dynamicHDR10, or too much for the rest, in case of  
this sequence. Depends on the intended meaning of this target.



Am 06.06.2017, 11:34 Uhr, schrieb Bhavna Hariharan  
<bhavna at multicorewareinc.com>:

> On Mon, May 29, 2017 at 3:43 PM, Mario *LigH* Rohkrämer <contact at ligh.de>
> wrote:
>
>> I believe that the "dynamicHDR10" sub-target is not yet included in the
>> "clean-generated" rule, causing previously compiled files not to be  
>> deleted
>> in this directory branch when a cleanup was desired.
>>
>> +----
>> Scanning dependencies of target dynamicHDR10
>> [  1%] Building CXX object dynamicHDR10/CMakeFiles/dynami
>> cHDR10.dir/metadataFromJson.cpp.obj
>> +----
>> # missing many more files here which are not built because their
>> compilation result probably still exists, despite a previous "make
>> clean-generated"
>>
>
> What are the files that aren't getting cleaned? I tried reproducing the
> issue, all the dhdr10 files are being deleted after "make clean" and they
> are re-generated after "make".
>
>
>> +----
>> [  6%] Built target dynamicHDR10
>> Scanning dependencies of target encoder
>> +----
>>
>> --
>>
>> Fun and success!
>> Mario *LigH* Rohkrämer
>> mailto:contact at ligh.de
>>
>> _______________________________________________
>> x265-devel mailing list
>> x265-devel at videolan.org
>> https://mailman.videolan.org/listinfo/x265-devel
>
>
>
>
> Regards,
>
> Bhavna Hariharan


-- 

Fun and success!
Mario *LigH* Rohkrämer
mailto:contact at ligh.de