[x265] [PATCH] encoder: expose BREF slice type in pic_out sliceType

[Aarthi Priya Thirumalai]

I think this change is not necessary since the sliceType in pic_out is
already set from m_lowres.sliceType.
So, if the B frame is a B_REF, this is reflected from the lowres.sliceType
already.

Is there any reason, you are explicitly setting it again?

On Fri, Nov 17, 2017 at 4:41 AM, John Stebbins <stebbins at jetheaddev.com>
wrote:

> # HG changeset patch
> # User John Stebbins <jstebbins.hb at gmail.com>
> # Date 1510861637 28800
> #      Thu Nov 16 11:47:17 2017 -0800
> # Branch stable
> # Node ID 5b61fc79bfa2d2bf85f8796001d711e5eed1fa1c
> # Parent  0b3ba15b33eaed5681f639697024525e9460bb31
> encoder: expose BREF slice type in pic_out sliceType
>
> The AppleTV 4K requires accurate frame dependency information in the
> mp4 sdtp box in order to play 2160p60 content.
>
> diff -r 0b3ba15b33ea -r 5b61fc79bfa2 source/encoder/encoder.cpp
> --- a/source/encoder/encoder.cpp        Tue Sep 05 11:21:24 2017 +0530
> +++ b/source/encoder/encoder.cpp        Thu Nov 16 11:47:17 2017 -0800
> @@ -857,6 +857,9 @@
>                  pic_out->pts = outFrame->m_pts;
>                  pic_out->dts = outFrame->m_dts;
>                  pic_out->sliceType = outFrame->m_lowres.sliceType;
> +                if (pic_out->sliceType == X265_TYPE_B &&
> +                    IS_REFERENCED(outFrame))
> +                    pic_out->sliceType = X265_TYPE_BREF;
>                  pic_out->planes[0] = recpic->m_picOrg[0];
>                  pic_out->stride[0] = (int)(recpic->m_stride *
> sizeof(pixel));
>                  if (m_param->internalCsp != X265_CSP_I400)
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20171120/5af99c77/attachment-0001.html>