[x265] [PATCH] new aq implementation

[Mateusz]

W dniu 28.12.2018 o 06:30, pooja at multicorewareinc.com pisze:
> diff -r 129416ec0479 -r 3cd0b5ed0b91 source/encoder/encoder.cpp
> --- a/source/encoder/encoder.cpp	Fri Dec 28 09:03:26 2018 +0530
> +++ b/source/encoder/encoder.cpp	Thu Dec 27 14:43:54 2018 +0530
> @@ -2839,6 +2839,12 @@
>      if (p->rc.aqMode == X265_AQ_NONE && p->rc.cuTree == 0)
>          p->rc.aqStrength = 0;
>  
> +    if (p->rc.hevcAq && p->rc.aqMode)
> +    {
> +        p->rc.aqMode = X265_AQ_NONE;
> +        x265_log(p, X265_LOG_WARNING, "hevc-aq enabled, disabling other aq-modes\n");
> +    }

If hevc-aq doesn't use cuTree, maybe it is better to make sure that p->rc.cuTree is 0 and simplify condition checking later
[...] = (m_param->rc.cuTree && !m_param->rc.hevcAq) ? [...]
There are places that the part '&& !m_param->rc.hevcAq' is missing.

Regards,
Mateusz