[x265] [Patch] Validate reconfigured params using encoder's configure

[Kalyan Goswami]

Understood. Yes, it makes sense.

Thanks,
Kalyan Goswami, PhD
Video Architect @ MulticoreWare
http: <http://www.multicorewareinc.com/>//www.multicorewareinc.com
<http://www.multicorewareinc.com/>
+91 9884989331


On Mon, Dec 31, 2018 at 12:28 PM Aruna Matheswaran <
aruna at multicorewareinc.com> wrote:

> Kalyan, Once encoder params are reconfigured, isn't it required to check
> that the reconfiguration doesn't violate encoder's configuration specified
> in encoder->configure(). I am assuming that encoder's configure() settings
> have higher priority over the reconfiguration settings.
>
> Thanks,
> Aruna
>
> On Mon, Dec 31, 2018 at 12:02 PM Kalyan Goswami <
> kalyan at multicorewareinc.com> wrote:
>
>> If it is not a reconfigureParam - then why we need to configure it?
>>
>> Thanks,
>> Kalyan Goswami, PhD
>> Video Architect @ MulticoreWare
>> http: <http://www.multicorewareinc.com/>//www.multicorewareinc.com
>> <http://www.multicorewareinc.com/>
>> +91 9884989331
>>
>>
>> On Thu, Dec 27, 2018 at 5:32 PM Aruna Matheswaran <
>> aruna at multicorewareinc.com> wrote:
>>
>>> # HG changeset patch
>>> # User Aruna Matheswaran <aruna at multicorewareinc.com>
>>> # Date 1545907588 -19800
>>> #      Thu Dec 27 16:16:28 2018 +0530
>>> # Node ID b5fc28ec5addfd2d35622ad838c91fba04247477
>>> # Parent  b14834a9d1c1864ea7e94d9cfed4e33f37e767c6
>>> Validate reconfigured params using encoder's configure
>>>
>>> diff -r b14834a9d1c1 -r b5fc28ec5add source/encoder/api.cpp
>>> --- a/source/encoder/api.cpp Mon Dec 17 12:15:47 2018 +0530
>>> +++ b/source/encoder/api.cpp Thu Dec 27 16:16:28 2018 +0530
>>> @@ -221,6 +221,7 @@
>>>      }
>>>      else
>>>      {
>>> +        encoder->configure(encoder->m_latestParam);
>>>          if (encoder->m_latestParam->scalingLists &&
>>> encoder->m_latestParam->scalingLists != encoder->m_param->scalingLists)
>>>          {
>>>              if (encoder->m_param->bRepeatHeaders)
>>>
>>> _______________________________________________
>>> x265-devel mailing list
>>> x265-devel at videolan.org
>>> https://mailman.videolan.org/listinfo/x265-devel
>>>
>> _______________________________________________
>> x265-devel mailing list
>> x265-devel at videolan.org
>> https://mailman.videolan.org/listinfo/x265-devel
>>
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20181231/e9936dcc/attachment-0001.html>