[x265] getopt_long() lets through ambiguous arguments like --nr

Mario *LigH* Rohkrämer contact at ligh.de
Wed Jul 11 09:41:58 CEST 2018


Joshua Bowman schrieb am 11.07.2018 um 06:36:
> GNU getopt allows abbreviated options, but it really SHOULD blow up when 
> an argument short-matches a name twice; instead it just merrily takes 
> the first one. It seems to be designed to allow a developer to brain 
> fart and insert the exact same argument twice without error, and this 
> patch will still allow that, but it WILL prevent something like --nr 
> that matches both --nr-intra and --nr-inter from just silently using the 
> first match. For some reason, no one ever thought to compare the actual 
> argument names.
> 
> This doesn't patch the -W path. No one cares about POSIX -W.
> 
> 
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel

"Thank you on behalf", Joshua. Just a general remark: The developers 
prefer patches also to be displayed in the normal mail body, for easier 
reviewing.


More information about the x265-devel mailing list