[x265] [PATCH] Fix: Build error in VS 11

Derek Buitenhuis derek.buitenhuis at gmail.com
Tue Jul 24 20:36:38 CEST 2018


On 24/07/2018 18:48, Ashok Kumar Mishra wrote:
> We have decided to back out the latest commit "Fix: Build error in VS 11", so that it can solve the building issue in ffmpeg.
> We are not going to support MSVC 11 anymore.

Hi,

As noted in my reply to j-b, my 2 cents is that this is still problematic.

No C, C++, or ABI (C or otherwise) standard, to my knowledge, guarantees
sizeof(bool), so passing a struct around which contains one may lead to
ABI problems, as far as I can tell.

Whether we think it's real or theoretical, though, is up for debate.

I do know at least one (oddball) compiler that used to set bool==int,
while most set bool==char.

- Derek


More information about the x265-devel mailing list