[x265] [PATCH] Update json11 to v1.0.0 release

Nomis101 🐝 Nomis101 at web.de
Thu Aug 1 15:43:53 CEST 2019


Am 25.07.19 um 23:58 schrieb Nomis101 🐝:
> Am 25.07.19 um 06:48 schrieb Aruna Matheswaran:
>>
>>
>> On Wed, Jul 24, 2019 at 9:59 PM Nomis101 🐝 <Nomis101 at web.de <mailto:Nomis101 at web.de>> wrote:
>>
>>     Hi Aruna,
>>
>>     could you specifiy what kind of errors and warnings you see on Windows? I don't have Windows, so I can not test or reproduce.
>>
>>
>> Please find the attached error log. 
>>
>>
>>
>>
>>
>>     Am 24.07.19 um 16:11 schrieb Aruna Matheswaran:
>>     > The patch applies on default and builds successfully in Mac and Linux, but gives build warnings and errors in windows. Could you please fix them and resend the patch?
>>
>>     _______________________________________________
>>     x265-devel mailing list
>>     x265-devel at videolan.org <mailto:x265-devel at videolan.org>
>>     https://mailman.videolan.org/listinfo/x265-devel
>>
>>
>>
>> --
>> Regards,
>> Aruna
>>
>> _______________________________________________
>> x265-devel mailing list
>> x265-devel at videolan.org
>> https://mailman.videolan.org/listinfo/x265-devel
>>
> 
> 
> Thanks for the error log. Interestingly, most of the lines the log mentions is not touched by my patch. The error messages look to me, like a compiler was
> used which did not fully support C++11. The Microsoft Visual Studio 12.0 (2013) you used for your test is known to have a limied C++11 implementation.
> See: https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140)
> For MSVC12 Compatibility I found this issue, which is still open: https://github.com/dropbox/json11/issues/2
> I think the only solution for this kind of errors are to use minimum Visual Studio 2015. What do you think? I'm pretty sure it will build on Windows with a
> newer MSVC with full C++11 implementation.
> 
> Best, Simon
> _______________________________________________
> x265-devel mailing list
> x265-devel at videolan.org
> https://mailman.videolan.org/listinfo/x265-devel
> 


As an alternative, I could cherry-pick json11 #92, to at least fix Issue #373. I don't know if this will help building on Microsoft Visual Studio 12.0, but
it would not introduce so many new lines.



More information about the x265-devel mailing list