[x265] bool should *not* be in a header file

[Vittorio Giovara]

Any C program including x265.h will fail to build because of this line

x265_zone *x265_zone_alloc(int zoneCount, bool isZoneFile);

Example output from ffmpeg

BEGIN /home/koda/tc/tmp/ffconf.JBakU0BM/test.c
    1    #include <x265.h>
    2    #include <stdint.h>
    3    long check_x265_api_get(void) { return (long) x265_api_get; }
    4    int main(void) { int ret = 0;
    5     ret |= ((intptr_t)check_x265_api_get) & 0xFFFF;
    6    return ret; }
END /home/koda/tc/tmp/ffconf.JBakU0BM/test.c
gcc -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DPIC -std=c11
-fomit-frame-pointer -fPIC -pthread -I/home/koda/stack/include/opus
-I/home/koda/stack/include/opus -L/home/koda/stack/lib -c -o
/home/koda/tc/tmp/ffconf.JBakU0BM/test.o
/home/koda/tc/tmp/ffconf.JBakU0BM/test.c
In file included from /home/koda/tc/tmp/ffconf.JBakU0BM/test.c:1:0:
/home/koda/stack/include/x265.h:1801:43: error: unknown type name 'bool'
 x265_zone *x265_zone_alloc(int zoneCount, bool isZoneFile);
                                           ^
Please set up a CI or something to prevent this kind of breakage.
Thank you
-- 
Vittorio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20190305/4b116685/attachment.html>