[x265] [PATCH] aarch64: replace ldr pseudo-instruction with adrp+add

[Fangrui Song]

On 2022-08-30, chen wrote:
>Hi Song,
>
>
>Thank you for your patch.
>
>
>However, syntax of ':lo12:' depends on compiler, so more general LDR is better in here.
>
>
>Regards,
>Min Chen

:lo12: is standard aarch64 assembly syntax.
Which aarch64 compiler supported by x265 does not support :lo12:?

>At 2022-08-30 02:33:37, "Fangrui Song" <maskray at google.com> wrote:
>>The ldr pseudo-instruction uses a literal pool, which is less efficient
>>and does not decrease the code size.
>>---
>> source/common/aarch64/asm.S | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>>diff --git a/source/common/aarch64/asm.S b/source/common/aarch64/asm.S
>>index 399c37cf2..2506f50aa 100644
>>--- a/source/common/aarch64/asm.S
>>+++ b/source/common/aarch64/asm.S
>>@@ -130,11 +130,9 @@ ELF     .size   \name, . - \name
>>         adrp            \rd, \val+(\offset)
>>         add             \rd, \rd, :lo12:\val+(\offset)
>>   .endif
>>-#elif defined(PIC)
>>+#else
>>         adrp            \rd, \val+(\offset)
>>         add             \rd, \rd, :lo12:\val+(\offset)
>>-#else
>>-        ldr             \rd, =\val+\offset
>> #endif
>> .endm
>>
>>--
>>2.37.2.672.g94769d06f0-goog
>>
>>_______________________________________________
>>x265-devel mailing list
>>x265-devel at videolan.org
>>https://mailman.videolan.org/listinfo/x265-devel

>_______________________________________________
>x265-devel mailing list
>x265-devel at videolan.org
>https://mailman.videolan.org/listinfo/x265-devel