[x265] [PATCH] Fix *BSD build

Michael Lackner michael.lackner at unileoben.ac.at
Thu Dec 1 09:13:27 UTC 2022


Hello,

While you're add this, I would like to suggest a minor cosmetic change to 
source/common/version.cpp as well. This would support more operating systems - including 
FreeBSD, DragonFly BSD and NetBSD - in x265's version information and change "Mac OS X" to 
"macOS", which is the current proper name of Apple's OS.

All of the added platforms have been tested by me (compilation & encoding).

Maybe "Unk-OS" could also be changed to "Unknown OS", but I'm unsure about that one, so I 
left it alone.


My sincere apologies for not submitting a proper patch according to your guidelines 
(https://bitbucket.org/multicoreware/x265_git/wiki/Contribute), but the process of 
creating one properly is just way too complicated for me. :( I'm also not a developer.

If this is unacceptable, I'll just have to keep patching the file manually. ;)


Best thing I managed:

  {source => ../source-new}/common/version.cpp | 12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/source/common/version.cpp b/../source-new/common/version.cpp
index 1c07d5a9d..a4d12eb49 100644
--- a/source/common/version.cpp
+++ b/../source-new/common/version.cpp
@@ -63,10 +63,20 @@
  #define ONOS    "[Linux]"
  #elif __OpenBSD__
  #define ONOS    "[OpenBSD]"
+#elif __FreeBSD__
+#define ONOS    "[FreeBSD]"
+#elif __NetBSD__
+#define ONOS    "[NetBSD]"
+#elif __DragonFly__
+#define ONOS    "[DragonFly BSD]"
+#elif __sun
+#define ONOS    "[Solaris]"
+#elif __HAIKU__
+#define ONOS    "[Haiku]"
  #elif  __CYGWIN__
  #define ONOS    "[Cygwin]"
  #elif __APPLE__
-#define ONOS    "[Mac OS X]"
+#define ONOS    "[macOS]"
  #else
  #define ONOS    "[Unk-OS]"
  #endif


Thanks for your work!


On 01/12/2022 04:11, Brad Smith wrote:
> On 11/21/2022 5:35 AM, Mahesh Pittala wrote:
>> Hello Brad Smith,
>>
>> Apologies for the delay and thanks for your patience.
>> We are looking into the issue now.
> 
> 
> Any update on this?

-- 
Michael Lackner
Lehrstuhl für Informationstechnologie (CiT)
Montanuniversität Leoben
Tel.: +43 3842 402 1505 | Mail: michael.lackner at unileoben.ac.at
Fax.: +43 3842 402 1502 | Web : http://institute.unileoben.ac.at/infotech


More information about the x265-devel mailing list