[x265] ARM patches

[chen]

Hi,


I haven't OS X environment, so I just guess the reason.
The GCC and LLVM use different symbol prefix.
We use "[private_prefix %+ _entropyStateBits]" in the x86 assembly code to suit these changes.
But use as "movrel  x1, x265_entropyStateBits" in aarch64, I don't found these little differences in previous code review.




Regards,

Min




At 2022-11-05 23:42:38, "Nomis101" <Nomis101 at web.de> wrote:
>Hi,
>
>same here, I'm seeing the same error as below if I try to build x265 (latest master) for macOS arm64 
>on macOS Ventura (Xcode 14.1).
>
>
>
>
>Am 04.11.22 um 08:39 schrieb Damiano Galassi:
>> Hi,
>> 
>> I’m getting the following error when trying to build on macOS arm64 since these patches:
>> 
>> Undefined symbols for architecture arm64:
>>    "x265_entropyStateBits", referenced from:
>>        _x265_costCoeffNxN_neon in libx265.a(pixel-util.S.o)
>>        _x265_10bit_costCoeffNxN_neon in libx265.a(pixel-util.S.o)
>>        _x265_12bit_costCoeffNxN_neon in libx265.a(pixel-util.S.o)
>>       (maybe you meant: _x265_entropyStateBits)
>> ld: symbol(s) not found for architecture arm64
>> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>> 
>>> Il giorno 29 ott 2022, alle ore 20:59, Pop, Sebastian <spop at amazon.com> ha scritto:
>>>
>>> Hello Mahesh,
>>>
>>> +x265-devel mailing-list
>>>
>>> Please find attached the last patches from my local git development tree that are not yet part of 
>>> the public x265 git repo.
>>> Could you please run smoke tests and integrate those patches to the public x265?
>>> Please let me know if you want me to address any further issue.
>>>
>>> Thanks,
>>> Sebastian
>>> ----------------------------------------------------------------------------------------------------
>>> *From:*Mahesh Pittala <mahesh at multicorewareinc.com <mailto:mahesh at multicorewareinc.com>>
>>> *Sent:*Friday, October 28, 2022 2:41:51 AM
>>> *To:*Pop, Sebastian
>>> *Cc:*Swathi Gurumani; Santhoshini Sekar; Gopi Satykrishna Akisetty
>>> *Subject:*[EXTERNAL] ARM patches
>>> *CAUTION*: This email originated from outside of the organization. Do not click links or open 
>>> attachments unless you can confirm the sender and know the content is safe.
>>>
>>>
>>> Hello Sebastian,
>>>
>>> I have observed a few ARM patches locally which are not pushed to the public x265 repo, we ran 
>>> smoke tests and it was successful.
>>>
>>> Can you please share it to x265 videoLAN so that we can push it ? If you have updated patches 
>>> please share them
>>>
>>> Thanks,
>>> Mahesh
>>>
>>>
>>>
>>>
>>> <0007-arm64-disable-scanPosLast_neon-on-Apple-processors.patch><0006-arm64-remove-two-fmov-instructions.patch><0005-arm64-do-not-use-FP-register-v15.patch><0004-arm64-use-better-addressing-modes-with-ld1-st1.patch><0003-arm64-register-several-ASM-routines.patch><0002-arm64-Register-the-assembly-routines-x265_satd_-_neo.patch><0001-arm64-port-costCoeffNxN.patch>_______________________________________________
>>> x265-devel mailing list
>>> x265-devel at videolan.org <mailto:x265-devel at videolan.org>
>>> https://mailman.videolan.org/listinfo/x265-devel <https://mailman.videolan.org/listinfo/x265-devel>
>> 
>> 
>> _______________________________________________
>> x265-devel mailing list
>> x265-devel at videolan.org
>> https://mailman.videolan.org/listinfo/x265-devel
>
>_______________________________________________
>x265-devel mailing list
>x265-devel at videolan.org
>https://mailman.videolan.org/listinfo/x265-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/x265-devel/attachments/20221106/4cb16c1d/attachment.htm>