[x265] [PATCH 14/14] Cleanup and Fix warnings

[Mario *LigH* Rohkrämer]

MSYS2/MinGW (32b here first), GCC 12.2, multilib build: Tons of 
warnings, closing with a linker error:

+----
[ 85%] Linking CXX shared library libx265.dll
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
multiple definition of `OrigPicBuffer::~OrigPicBuffer()'; CMakeF
iles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
multiple definition of `OrigPicBuffer::~OrigPicBuffer()'; CMakeF
iles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x2f0): 
multiple definition of `OrigPicBuffer::recycleOrigPicList()'; CM
akeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x2f0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
multiple definition of `TemporalFilter::TemporalFilter()'; CMake
Files/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
multiple definition of `TemporalFilter::TemporalFilter()'; CMake
Files/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x410): 
multiple definition of `TemporalFilter::init(x265_param const*)'
; 
CMakeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x410): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x4a0): 
multiple definition of `TemporalFilter::createRefPicInfo(Tempora
lFilterRefPicInfo*, x265_param*)'; 
CMakeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x4a0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main10.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x7170): 
multiple definition of `TemporalFilter::destroyRefPicInfo(Tempo
ralFilterRefPicInfo*)'; 
CMakeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x61d0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
multiple definition of `OrigPicBuffer::~OrigPicBuffer()'; CMakeF
iles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
multiple definition of `OrigPicBuffer::~OrigPicBuffer()'; CMakeF
iles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x140): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x2f0): 
multiple definition of `OrigPicBuffer::recycleOrigPicList()'; CM
akeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x2f0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
multiple definition of `TemporalFilter::TemporalFilter()'; CMake
Files/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
multiple definition of `TemporalFilter::TemporalFilter()'; CMake
Files/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x3a0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x410): 
multiple definition of `TemporalFilter::init(x265_param const*)'
; 
CMakeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x410): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x4a0): 
multiple definition of `TemporalFilter::createRefPicInfo(Tempora
lFilterRefPicInfo*, x265_param*)'; 
CMakeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x4a0): 
first defined here
G:/MABS/msys64/mingw32/bin/../lib/gcc/i686-w64-mingw32/12.2.0/../../../../i686-w64-mingw32/bin/ld.exe: 
.\libx265_main12.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x7170): 
multiple definition of `TemporalFilter::destroyRefPicInfo(Tempo
ralFilterRefPicInfo*)'; 
CMakeFiles/x265-shared.dir/objects.a(temporalfilter.cpp.obj):temporalfilter:(.text+0x61d0): 
first defined here
collect2.exe: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/x265-shared.dir/build.make:253: libx265.dll] 
Error 1
make[1]: *** [CMakeFiles/Makefile2:228: CMakeFiles/x265-shared.dir/all] 
Error 2
make: *** [Makefile:136: all] Error 2
G:\MABS\msys64\mingw32\bin\strip.exe: 'libx265.dll': No such file
G:\MABS\msys64\mingw32\bin\strip.exe: 'x265.exe': No such file

+----

-- 

Fun and success!

Mario *LigH* Rohkrämer
maito:contact at ligh.de