[x265] CHECK bStrictCbr has either misleading message or the check is wrong

Zoff zoff at zoff.cc
Sun Dec 1 18:49:01 UTC 2024


Hi!

in
https://bitbucket.org/multicoreware/x265_git/raw/fa2770934b8f3d88aa866c77f27cb63f69a9ed39/source/common/param.cpp

     CHECK(param->rc.bStrictCbr && (param->rc.bitrate <= 0 || param->rc.vbvBufferSize <=0),
           "Strict-cbr cannot be applied without specifying target bitrate or vbv bufsize");

it says "or" in the error message. but the check checks that BOTH bitrate AND vbvBufferSize need to be set.
so either the error message is wrong, or the CHECK is wrong.

i am not sure which one, but one needs to be changed i think.

	cheers,
	Zoff.


More information about the x265-devel mailing list