[Android] [PATCH] Use MRLs and libvlc_media_new_location everywhere

[XilasZ]

-        if (mTitle == null)
-            return mFile.getName().substring(0,
mFile.getName().lastIndexOf('.'));
-        else
-            return mTitle;
+        /* should never happen */
+        assert (mTitle != null);
+        return mTitle;

i'm not sure it's true, vlc can answers with null metadata i think,
especially for video files without metadata.

+    /**
+     * To maintain compatibility in a couple of places
+     * Only used internally now
+     */
+    private File mFile_internal;

I'm not sur it is still needed.


+                    } catch (URISyntaxException e) {
+                        // URISyntax
+                        // Exception: Cannot happen
+                        // But Java forced me
+                    }
+

java forced you because of this :
+    public static URI VLCPathToURI(String path) throws URISyntaxException {

you can do the try/catch inside VLCPathToURI, then you won't need to add it
at each use of VLCPathToURI.


The patch looks OK to me (didn't had time to test it yet) we can merge it
and fix stuff after if necessary.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/android/attachments/20120321/0cc0012b/attachment.html>