[Android] PreferencesActivity: clean up the cleanup

Jean-Baptiste Kempf jb at videolan.org
Wed Mar 13 16:51:12 CET 2013


On 13 Mar, Edward Wang wrote :
> >+    <string name="enable_time_stretching_audio_summary">Speed up and
> >slow down audio without changing the pitch (requires a fast
> >     device).</string>
> >This is wrong, people have no idea what pitch is.
> I would disagree here; I think people generally know that pitch is
> high and low tones from listening to music.

I disagree. Ask around yourself.

> >+    <string name="subtitles_text_encoding">Subtitle text
> >encoding</string>
> >There are more than one subtitle.
> The correct English form is "Subtitle text encoding". Subtitle is
> the adjective describing what kind of text. So "subtitle text" is an
> adjective phrase describing what kind of encoding.

No, it is Subtitles "text encoding".

> >Moving android:entries="@array/chroma_formats" is wrong too. There is a
> >good reason to put it at the top of the perf category...
> And the reason would be...

Because this it the thing that will work almost everywhere, and improve
the most perf. iOMX is working randomly and Audioscaling is the one
costing MORE cpu.

> >Removing android:summary="@string/screen_orientation_summary" needs also
> >a good reason.
> >
> I think that it is pretty obvious to the user what "screen
> orientation" means.

It is not, notably because this affects only VIDEO FULLSCREEN, not audio
or video list. So this is not obvious.
Moreover, have you tried a screen reader on Android?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the Android mailing list