[libbluray-devel] libbluray 1.0.1 build warnings

[Xavier Bachelot]

Hi,

While building libbluray 1.0.1, I noticed a couple build warnings and 
thought that could be of interest to report :

src/file/dir_posix.c: In function '_dir_read_posix':
src/file/dir_posix.c:51:5: warning: 'readdir_r' is deprecated 
[-Wdeprecated-declarations]
      result = readdir_r((DIR*)dir->internal, &e, &p_e);
      ^~~~~~
In file included from src/file/dir_posix.c:32:0:
/usr/include/dirent.h:183:12: note: declared here
  extern int readdir_r (DIR *__restrict __dirp,
             ^~~~~~~~~

src/libbluray/bluray.c: In function '_check_bdj':
src/libbluray/bluray.c:907:47: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
              case 2: bd->disc_info.bdj_handled = 1;
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
src/libbluray/bluray.c:908:13: note: here
              case 1: bd->disc_info.libjvm_detected = 1;
              ^~~~

src/libbluray/decoders/graphics_controller.c: In function 'gc_run':
src/libbluray/decoders/graphics_controller.c:2018:19: warning: this 
statement may fall through [-Wimplicit-fallthrough=]
              param = !gc->popup_visible;
              ~~~~~~^~~~~~~~~~~~~~~~~~~~
src/libbluray/decoders/graphics_controller.c:2021:9: note: here
          case GC_CTRL_POPUP:
          ^~~~

src/util/bits.c: In function 'bs_read':
src/util/bits.c:221:9: warning: ignoring return value of 'file_seek', 
declared with attribute warn_unused_result [-Wunused-result]
          file_seek(bs->fp, bs->pos, SEEK_SET);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/util/bits.c: In function 'bs_skip':
src/util/bits.c:248:9: warning: ignoring return value of 'file_seek', 
declared with attribute warn_unused_result [-Wunused-result]
          file_seek(bs->fp, bs->pos, SEEK_SET);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Also, doxygen (1.8.13) reports obsolete tags :

warning: Tag `SYMBOL_CACHE_SIZE' at line 290 of file 
`./doc/doxygen-config' has become obsolete.
warning: Tag `SHOW_DIRECTORIES' at line 490 of file 
`./doc/doxygen-config' has become obsolete.
warning: Tag `HTML_ALIGN_MEMBERS' at line 847 of file 
`./doc/doxygen-config' has become obsolete.
warning: Tag `USE_INLINE_TREES' at line 1032 of file 
`./doc/doxygen-config' has become obsolete.
warning: Tag `XML_SCHEMA' at line 1257 of file `./doc/doxygen-config' 
has become obsolete.
warning: Tag `XML_DTD' at line 1263 of file `./doc/doxygen-config' has 
become obsolete.

Regards,
Xavier