[libbluray-devel] [PATCH 0/2] OpenJDK 9 compatibility

[Sebastian Ramacher]

Hi

On 2018-03-21 09:16:37, Petri Hintukainen wrote:
> ma, 2018-03-19 kello 23:12 +0100, sebastian+lists at ramacher.at
> kirjoitti:
> > From: Sebastian Ramacher <sramacher at debian.org>
> > 
> > Debian unstable switched to OpenJDK 9 as default Java implementation
> > recently.
> > Because of thatchange, libbluray started to fail building.
> 
> Java 9 is currently not an option for libbluray. I looked at the
> changes required for Java 9 couple of months ago. Even if we fix build
> time issues, new packaging model of JVM 9 prevents loading the .jar
> file. There are also several unresolved runtime issues.
> 
> It should be possible to compile the .jar file with JDK 9 if sources
> are compiled against older Java rt libraries. This requires older JRE
> (but not JDK) for build and runtime.

So what's the plan with respect to Java 9 support? As I understand your mail
(and the code) correctly the situation is the following:
* We could build the jar with OpenJDK 9 using an old JRE, but it will only work with < 9.
* Even though it libbluray doesn't work with Java 9, _load_jvm will happily pick
  it if /usr/lib/jvm/default-java points to Java 9 (which it does now on
  Debian). It would pick it even if OpenJDK < 9 would be available.

For the time being I can of course patch it to ignore anything Java 9 related
and force the dependencies accordingly. That might work as a workaround for the
near future, but will sooner or later become a problem.

Cheers

> 
> > The first patch is simple - support for everything before 1.6 was
> > removed. The second patch is only build-tested.
> >
> > Sebastian Ramacher (2):
> >   bdj: bump source and target to 1.6
> >   bdj: fix requestFocus arguments
> 
> The second patch won't build or run with Java < 9.
> 
> We can either patch FocusEvent and CausedFocusEvent to work in both
> versions, or add new version of BDFramePeer.java for Java 9. If we add
> new version, resulting .jar file won't work with JRE < 9. But I don't
> know if it will be an issue if we need to split the .jar anyway ...
> 
> > src/libbluray/bdj/build.xml                                | 4 ++--
> >  src/libbluray/bdj/java-j2se/java/awt/peer/BDFramePeer.java | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> _______________________________________________
> libbluray-devel mailing list
> libbluray-devel at videolan.org
> https://mailman.videolan.org/listinfo/libbluray-devel

-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/libbluray-devel/attachments/20180321/c937f88c/attachment.sig>