[libdvdnav-devel] [PATCH 1/2] src/ifo_read.c: Fix a couple of fprintf format strings

Jean-Baptiste Kempf jb at videolan.org
Fri Oct 24 04:08:25 CEST 2014


LGTM.

On 23 Oct, Andrew Clayton wrote :
> In ifoRead_PTL_MAIT() there are a couple of fprintf()'s displaying an
> index value, this index value is an unsigned int, but the format strings
> had %d rather than %u.
> 
> Signed-off-by: Andrew Clayton <andrew at digital-domain.net>
> ---
>  src/ifo_read.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ifo_read.c b/src/ifo_read.c
> index 4659136..b5b774d 100644
> --- a/src/ifo_read.c
> +++ b/src/ifo_read.c
> @@ -1378,7 +1378,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofile) {
>      if(!DVDFileSeek_(ifofile->file,
>                       ifofile->vmgi_mat->ptl_mait * DVD_BLOCK_LEN
>                       + ptl_mait->countries[i].pf_ptl_mai_start_byte)) {
> -      fprintf(stderr, "libdvdread: Unable to seek PTL_MAIT table at index %d.\n",i);
> +      fprintf(stderr, "libdvdread: Unable to seek PTL_MAIT table at index %u.\n",i);
>        free(ptl_mait->countries);
>        free(ptl_mait);
>        ifofile->ptl_mait = NULL;
> @@ -1393,7 +1393,7 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofile) {
>      }
>      memset(pf_temp, 0, info_length);
>      if(!(DVDReadBytes(ifofile->file, pf_temp, info_length))) {
> -      fprintf(stderr, "libdvdread: Unable to read PTL_MAIT table at index %d.\n",i);
> +      fprintf(stderr, "libdvdread: Unable to read PTL_MAIT table at index %u.\n",i);
>        free(pf_temp);
>        free_ptl_mait(ptl_mait, i);
>        ifofile->ptl_mait = NULL;
> -- 
> 1.9.3
> 
> _______________________________________________
> libdvdnav-devel mailing list
> libdvdnav-devel at videolan.org
> https://mailman.videolan.org/listinfo/libdvdnav-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the libdvdnav-devel mailing list