[libdvdnav-devel] [PATCH 2/2] src/ifo_read.c: Reduce the scope of some variables
Jean-Baptiste Kempf
jb at videolan.org
Fri Oct 24 04:08:47 CEST 2014
You could even use it directly in the for().
On 23 Oct, Andrew Clayton wrote :
> The unsigned int i variable in ifoRead_PTL_MAIT(), ifoRead_VTS_TMAPT()
> and ifoRead_PGCI_UT() can be moved into the second if block in each
> case.
>
> Signed-off-by: Andrew Clayton <andrew at digital-domain.net>
> ---
> src/ifo_read.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/ifo_read.c b/src/ifo_read.c
> index b5b774d..b5dc6ce 100644
> --- a/src/ifo_read.c
> +++ b/src/ifo_read.c
> @@ -1424,12 +1424,12 @@ int ifoRead_PTL_MAIT(ifo_handle_t *ifofile) {
> }
>
> void ifoFree_PTL_MAIT(ifo_handle_t *ifofile) {
> - unsigned int i;
> -
> if(!ifofile)
> return;
>
> if(ifofile->ptl_mait) {
> + unsigned int i;
> +
> for(i = 0; i < ifofile->ptl_mait->nr_of_countries; i++) {
> free(ifofile->ptl_mait->countries[i].pf_ptl_mai);
> }
> @@ -1558,12 +1558,12 @@ int ifoRead_VTS_TMAPT(ifo_handle_t *ifofile) {
> }
>
> void ifoFree_VTS_TMAPT(ifo_handle_t *ifofile) {
> - unsigned int i;
> -
> if(!ifofile)
> return;
>
> if(ifofile->vts_tmapt) {
> + unsigned int i;
> +
> for(i = 0; i < ifofile->vts_tmapt->nr_of_tmaps; i++)
> if(ifofile->vts_tmapt->tmap[i].map_ent)
> free(ifofile->vts_tmapt->tmap[i].map_ent);
> @@ -2112,12 +2112,12 @@ int ifoRead_PGCI_UT(ifo_handle_t *ifofile) {
>
>
> void ifoFree_PGCI_UT(ifo_handle_t *ifofile) {
> - unsigned int i;
> -
> if(!ifofile)
> return;
>
> if(ifofile->pgci_ut) {
> + unsigned int i;
> +
> for(i = 0; i < ifofile->pgci_ut->nr_of_lus; i++) {
> ifoFree_PGCIT_internal(&ifofile->pgci_ut->lu[i].pgcit);
> }
> --
> 1.9.3
>
> _______________________________________________
> libdvdnav-devel mailing list
> libdvdnav-devel at videolan.org
> https://mailman.videolan.org/listinfo/libdvdnav-devel
--
With my kindest regards,
--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
More information about the libdvdnav-devel
mailing list