[libdvdnav-devel] [PATCH] Cleanup ifoFree()

Lawrence D'Oliveiro ldo at geek-central.gen.nz
Tue Jan 6 04:28:21 CET 2015


I wrote:

> On Mon, 5 Jan 2015 19:31:49 -0700, Steve Dibb wrote:
> 
> >    if(strncmp("DVDVIDEO-VMG", vmgi_mat->vmg_identifier, 12) != 0) {
> >      free(ifofile->vmgi_mat);
> > -    ifofile->vmgi_mat = 0;
> > +    ifofile->vmgi_mat = NULL;
> >      return 0;
> >    }
> 
> Umm, just a thought, shouldn’t that “!=” be “==”? strncmp(3) returns
> zero on a match.

Oh, I get it. It’s checking for a MISmatch against the type of IFO it
is expecting.

Ignore my previous comment. :)


More information about the libdvdnav-devel mailing list