[libdvdnav-devel] [DVDnav-discuss] [PATCH] Cleanup ifoFree()

Paul Menzel paulepanter at users.sourceforge.net
Tue Jan 6 08:46:23 CET 2015

Dear Steve,

thank you for your analysis and patch.

Am Montag, den 05.01.2015, 19:31 -0700 schrieb Steve Dibb:

For the commit message summary/subject line, as it the verb here, please
write “Clean up” with a space.

    Clean up ifoFree()

> - Move all ifoFree_*() functions only called once directly into
>   ifoFree()
> - Proper checks for NULL pointers, freeing pointers

In your follow-up message you write about ISOs you can now parse. Can
you list those or just give some examples, please?

    git commit --amend

makes it easy to amend the last commit.

> ---
>  src/dvdread/ifo_read.h |  13 +-
>  src/ifo_read.c         | 503
>   ++++++++++++++++++++++++------------------------- 2 files changed,

Your MUA added an automatic line break here, making it difficult to
apply the patch with `git am`. There is probably an option to avoid
automatic line breaks for certain parts of a message.

>   244 insertions(+), 272 deletions(-)
> diff --git a/src/dvdread/ifo_read.h b/src/dvdread/ifo_read.h
> index 97f4179..d29c3f9 100644



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/libdvdnav-devel/attachments/20150106/a9554499/attachment.sig>

More information about the libdvdnav-devel mailing list