[libdvdnav-devel] [PATCH] Cleanup ifoFree()

[Steve Dibb]

On Tue, 6 Jan 2015 09:43:50 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> On Mon, Jan 05, 2015 at 07:31:49PM -0700, Steve Dibb wrote:
> > --- a/src/ifo_read.c
> > +++ b/src/ifo_read.c
> > @@ -87,9 +87,7 @@ static int
> > ifoRead_VOBU_ADMAP_internal(ifo_handle_t
> > -  ifoFree_VOBU_ADMAP(ifofile);
> > +  // ifoFree_VOBU_ADMAP(ifofile);
> 
> Why do you keep this commented-out cruft around?  More below ...

It's a work in progress.  I'm more interested in feedback than commits
atm, which is great, because that's what I'm getting. :)

> > if(ifofile->pgci_ut->lu[a].pgcit->pgci_srp[b].pgc->command_tbl) {
> > +
> > free(ifofile->pgci_ut->lu[a].pgcit->pgci_srp[b].pgc->command_tbl->pre_cmds);
> 
> Your MUA mangles patches, you should attach them instead of pasting
> inline.

OK.

> > @@ -525,19 +645,19 @@ static int ifoRead_VMG(ifo_handle_t *ifofile)
> > { 
> >    if(!DVDFileSeek_(ifofile->file, 0)) {
> >      free(ifofile->vmgi_mat);
> > -    ifofile->vmgi_mat = 0;
> > +    ifofile->vmgi_mat = NULL;
> 
> These should be in a separate patch IMO.

Sounds good.

Steve