[libdvdnav-devel] [DVDnav-discuss] [PATCH] Cleanup ifoFree()

Steve Dibb beandog at gentoo.org
Tue Jan 6 18:52:58 CET 2015

> In your follow-up message you write about ISOs you can now parse. Can
> you list those or just give some examples, please?

Ok.  I can do that.  The biggest factor I should have mentioned was
that fixing ifoFree_PGC() was where it would make most everything
segfault.  Fixing the other pointers everywhere else fixed a lot as
well, but cleaning up the PGC was the major one.

>     git commit --amend
> makes it easy to amend the last commit.
> > ---
> >  src/dvdread/ifo_read.h |  13 +-
> >  src/ifo_read.c         | 503
> >   ++++++++++++++++++++++++------------------------- 2 files changed,
> Your MUA added an automatic line break here, making it difficult to
> apply the patch with `git am`. There is probably an option to avoid
> automatic line breaks for certain parts of a message.
> >   244 insertions(+), 272 deletions(-)
> > 
> > diff --git a/src/dvdread/ifo_read.h b/src/dvdread/ifo_read.h
> > index 97f4179..d29c3f9 100644

What's the best approach for using git and sending diffs to the ML for
review?  I'm not expecting them to be applied, just reviewed.


More information about the libdvdnav-devel mailing list