[libdvdnav-devel] [DVDnav-discuss] [PATCH] Cleanup ifoFree()

[Steve Dibb]

On Tue, 06 Jan 2015 23:45:18 +0100
Paul Menzel <paulepanter at users.sourceforge.net> wrote:

> Am Dienstag, den 06.01.2015, 10:52 -0700 schrieb Steve Dibb:
> > > In your follow-up message you write about ISOs you can now parse.
> > > Can you list those or just give some examples, please?
> > 
> > Ok.  I can do that.  The biggest factor I should have mentioned was
> > that fixing ifoFree_PGC() was where it would make most everything
> > segfault.  Fixing the other pointers everywhere else fixed a lot as
> > well, but cleaning up the PGC was the major one.
> 
> Understood.

Here's the sources of the broken ISOs that Thomas provided, that I'm
using as a reference:
https://www.dropbox.com/s/h1x6laz1jsapk3a/crashes.tar.xz which I've
also mirrored here: http://bluray.beandog.org/dvd_info/crashes.tar.xz

There's 300 fuzzed ISOs he made for us.  To give some quick numbers,
originally dvd_info could parse 15 out of the 300 and return with a
successful exit code.  With the changes to ifoFree() and with a few
small changes to dvd_info that checks for the program chain, it can now
parse 173 out of the 300.

I haven't looked extensively at what the other issues are just yet,
other than noticing that DVDOpenFile() is having problems.

Here's the repo for dvd_info: https://github.com/beandog/dvd_info

Steve