[libdvdnav-devel] [DVDnav-discuss] [PATCH] Cleanup ifoFree()
paulepanter at users.sourceforge.net
Tue Jan 6 23:45:41 CET 2015
Am Dienstag, den 06.01.2015, 10:52 -0700 schrieb Steve Dibb:
> > In your follow-up message you write about ISOs you can now parse. Can
> > you list those or just give some examples, please?
> Ok. I can do that. The biggest factor I should have mentioned was
> that fixing ifoFree_PGC() was where it would make most everything
> segfault. Fixing the other pointers everywhere else fixed a lot as
> well, but cleaning up the PGC was the major one.
> > git commit --amend
> > makes it easy to amend the last commit.
> > > ---
> > > src/dvdread/ifo_read.h | 13 +-
> > > src/ifo_read.c | 503
> > > ++++++++++++++++++++++++------------------------- 2 files changed,
> > Your MUA added an automatic line break here, making it difficult to
> > apply the patch with `git am`. There is probably an option to avoid
> > automatic line breaks for certain parts of a message.
> > > 244 insertions(+), 272 deletions(-)
> > >
> > > diff --git a/src/dvdread/ifo_read.h b/src/dvdread/ifo_read.h
> > > index 97f4179..d29c3f9 100644
> What's the best approach for using git and sending diffs to the ML for
> review? I'm not expecting them to be applied, just reviewed.
I think your way is fine. Just select all the text after pasting the
output of `git format-patch -1` and then choose leaving the preformat(?)
There is also `git send-email`, which sends the mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: This is a digitally signed message part
More information about the libdvdnav-devel