[libdvdnav-devel] dvdread: beandog branch with fixes

[Andrew Clayton]

On Thu, 8 Jan 2015 23:34:14 -0700, Steve Dibb wrote:

> While I appreciate everyone's help in trying to get me up to speed on
> git, I was spending more time playing with it than actually coding, so
> I am trying something else instead.  I created my own branch and
> pushed the changes to github.  Hopefully someone smarter than me can
> figure out how to pull those into the main branch.
> 
> You can see all the commits here:
> https://github.com/beandog/dvdread/commits/beandog

Hi Steve,

You obviously spent a bit of time on this.

While I'll bow to the wishes of our maintainer overload ;) I'll make
some general comments below.

1) I think you still need to send actual patches to the list for
_review_

To do this, configure git-send-email (you may need to install some
extra packages; git-email)

Here's what I have in my ~/.gitconfig (redacted)

[sendemail]
	smtpserver = YOUR OUTGOING MAIL SERVER
	envelopesender = auto
	suppresscc = self

and then in my .git/config for libdvdread I have (the above can go in
here instead if you wish)

[sendemail]
	to = libdvdnav-devel at videolan.org

And then to quote the git-send-email man page

	$ git format-patch --cover-letter -M origin/master -o outgoing/
	$ edit outgoing/0000-*
	$ git send-email outgoing/*

2) While I'm not sure if it's a hard and fast rule in this
project, you should probably sign-off your work.

Adding -s to the commit command will add a Signed-off-by: line for you.

See 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n358
for what this is all about.

3) I had a quick look through some of your commits, now all the ones I
saw only had a subject line and no commit message, maybe they don't
require an explanation, but is that really true of them all? (note, I
haven't actually looked at them all)

4) This commit
https://github.com/beandog/dvdread/commit/979da36c741e80934dedfbe8e285a7914a906559
still looks a bit strange to me, setting something to NULL right before
returning...

Cheers,
Andrew