[libdvdnav-devel] [PATCH 22/33] Check for positive integer values

[Jean-Baptiste Kempf]

On 18 Jan, Andrew Clayton wrote :
> > -  if(cmd_tbl->nr_of_pre != 0) {
> > +  if(cmd_tbl->nr_of_pre > 0) {
> 
> Hmm, would simply
> 
> 	if(cmd_tbl->nr_of_pre)
> 
> not perhaps be better?, it at least has the same meaning as the old
> code and for me is quicker to read.

Ah no, please avoid that for non-boolean or non-pointer values.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device